Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932451AbcCQHeI (ORCPT ); Thu, 17 Mar 2016 03:34:08 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:36198 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932217AbcCQHeG (ORCPT ); Thu, 17 Mar 2016 03:34:06 -0400 MIME-Version: 1.0 In-Reply-To: <871t7a54sd.wl%kuninori.morimoto.gx@renesas.com> References: <8760wnfe3r.wl%kuninori.morimoto.gx@renesas.com> <874mc7fe29.wl%kuninori.morimoto.gx@renesas.com> <871t7a54sd.wl%kuninori.morimoto.gx@renesas.com> Date: Thu, 17 Mar 2016 08:34:05 +0100 X-Google-Sender-Auth: boziqbtGfc7K2xopp4KjfDRP1_w Message-ID: Subject: Re: [PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug From: Geert Uytterhoeven To: Kuninori Morimoto Cc: Laurent Pinchart , Geert Uytterhoeven , Linus Walleij , Magnus , Simon , linux-renesas-soc@vger.kernel.org, "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1459 Lines: 50 Hi Morimoto-san, On Thu, Mar 17, 2016 at 1:30 AM, Kuninori Morimoto wrote: >> > From: Kuninori Morimoto >> > >> > Current sh_pfc can't indicate GPSR/IPSR/MOD_SEL name for debug. >> > Of course we can get it from indicated register address, but it >> > is not convenient. This patch enables to indicate these. >> > >> > Signed-off-by: Kuninori Morimoto >> >> > --- a/drivers/pinctrl/sh-pfc/sh_pfc.h >> > +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h >> > @@ -94,6 +94,7 @@ struct pinmux_func { >> > }; >> > >> > struct pinmux_cfg_reg { >> > + const char *name; >> >> Have you looked at the size increase, esp. for multi-platform kernels? > > Indeed. > I checked its size by "ls -l", and the result is below. > zImage size was... reduced ?? > > without this patch > > 10661888 Image > 3544032 zImage > > with this patch > > 10661888 Image > 3543432 zImage Please use "size drivers/pinctrl/sh-pfc/built-in.o". zImage size is affected by section alignment and crompression. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds