Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932374AbcCQH4e (ORCPT ); Thu, 17 Mar 2016 03:56:34 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:33622 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752954AbcCQH43 (ORCPT ); Thu, 17 Mar 2016 03:56:29 -0400 Subject: Re: Nokia N900 - audio TPA6130A2 problems To: Sebastian Reichel References: <201507251228.27128@pali> <201601050034.12810@pali> <20160306152339.GA428@earth> <201603121342.33099@pali> <56E68B71.2030202@ti.com> <20160316133319.GR8413@pali> <20160316144709.GA3389@earth> <56E9A42B.3010209@gmail.com> <56E9A6D9.7000003@ti.com> <56E9B910.7000904@gmail.com> <20160317004917.GA6750@earth> Cc: Grygorii Strashko , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Peter Ujfalusi , Jarkko Nikula , Tony Lindgren , Lars-Peter Clausen , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Pavel Machek , Aaro Koskinen , Nishanth Menon , merlijn@wizzup.org From: Ivaylo Dimitrov Message-ID: <56EA6326.4000702@gmail.com> Date: Thu, 17 Mar 2016 09:56:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160317004917.GA6750@earth> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1150 Lines: 40 Hi, On 17.03.2016 02:49, Sebastian Reichel wrote: > > mh both, the power gpio is turned off in tpa6130a2_power(0). I guess > if you don't see the problem during probe() everything works? > > I have another idea though: In opposit to the gpio, the regulator > may also be referenced by something else/already enabled. I guess > adding a sleep after the regulator_enable() is worth a try. > > Also I wonder if the same happens, if you avoid having the module > available during boot and instead load it once everything has > settled. That would rule out any side-effects of other modules > being probed on the same i2c bus. Well, I think I've figured it out - input pullups are not enabled on i2c bus pins, in stock kernel we have: ./devmem2 0x480021BC Value at address 0x480021BC (0x4001f1bc): 0x1180118 ./devmem2 0x480021C0 Value at address 0x480021C0 (0x4001f1c0): 0x1180118 in mainline ./devmem2 0x480021BC Value at address 0x480021BC (0xb6ff01bc): 0x1000100 ./devmem2 0x480021C0 Value at address 0x480021C0 (0xb6f6d1c0): 0x1000100 I wonder how i2c devices work at all :) Will fix the board DTS file later on an will report Regards, Ivo