Message-ID: <56ea6f98.418f1c0a.cb040.ffffa357@mx.google.com>
Date: Thu, 17 Mar 2016 10:49:28 +0200
From: Ebru Akagunduz <ebru.akagunduz@gmail.com>
To: vbabka@suse.cz, linux-mm@kvack.org
Cc: hughd@google.com, riel@redhat.com, akpm@linux-foundation.org,
        kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com,
        aarcange@redhat.com, iamjoonsoo.kim@lge.com, gorcunov@openvz.org,
        linux-kernel@vger.kernel.org, mgorman@suse.de, rientjes@google.com,
        aneesh.kumar@linux.vnet.ibm.com, hannes@cmpxchg.org, mhocko@suse.cz,
        boaz@plexistor.com
Subject: Re: [PATCH v3 1/2] mm, vmstat: calculate particular vm event
References: <1457991611-6211-1-git-send-email-ebru.akagunduz@gmail.com>
 <1457991611-6211-2-git-send-email-ebru.akagunduz@gmail.com>
 <56E981A5.30401@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56E981A5.30401@suse.cz>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 765
Lines: 21

On Wed, Mar 16, 2016 at 04:54:13PM +0100, Vlastimil Babka wrote:
> On 03/14/2016 10:40 PM, Ebru Akagunduz wrote:
> >Currently, vmstat can calculate specific vm event with all_vm_events()
> >however it allocates all vm events to stack. This patch introduces
> >a helper to sum value of a specific vm event over all cpu, without
> >loading all the events.
> >
> >Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
> >Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> 
> Kirill was modest enough to not point this out, but this should IMHO
> have at least:
> 
> Suggested-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> 
> Otherwise:
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> 
Sure. I'll add Suggested-by in next version.

Thanks.