Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933054AbcCQIuf (ORCPT ); Thu, 17 Mar 2016 04:50:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:60968 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932982AbcCQIuc (ORCPT ); Thu, 17 Mar 2016 04:50:32 -0400 Date: Thu, 17 Mar 2016 09:50:28 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Jessica Yu cc: Josh Poimboeuf , Miroslav Benes , Petr Mladek , Rusty Russell , Steven Rostedt , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] Livepatch module notifier cleanup In-Reply-To: <1458176139-17455-1-git-send-email-jeyu@redhat.com> Message-ID: References: <1458176139-17455-1-git-send-email-jeyu@redhat.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1309 Lines: 35 On Wed, 16 Mar 2016, Jessica Yu wrote: > These are the remaining 2 patches that came from the original ftrace/livepatch > module notifier patchset found here: https://lkml.org/lkml/2016/2/8/1180 > > Basically, the patchset does a bit of module.c cleanup (patch 1) in > preparation for the klp_module_{coming,going} calls (patch 2). We decided > to stop relying on the module notifier callchain in favor of hard-coding > the appropriate livepatch function calls that handle coming and going > modules. Hard-coding these calls will guarantee that ftrace and livepatch > exit/initialization routines are called in the correct order without > relying on module notifiers. > > The patches should be nearly exactly the same as those from the previous > discussion, except in patch 2 I've added back the #if IS_ENABLED(CONFIG_LIVEPATCH) > guard in livepatch.h. > > Patches based on linux-next. > > v2 discussion found here: > https://lkml.kernel.org/g/1457726628-9171-1-git-send-email-jeyu@redhat.com > > v3: > - Remove confusing comment above klp_module_going() > - Place prepare_coming_module() after complete_formation() > - Fix small race in klp_module_coming() by setting mod->klp_alive > to false in the error path I've applied v3 to for-4.6/notifier-cleanup. Thanks! -- Jiri Kosina SUSE Labs