Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935791AbcCQLZ2 (ORCPT ); Thu, 17 Mar 2016 07:25:28 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:39470 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932445AbcCQLZ1 (ORCPT ); Thu, 17 Mar 2016 07:25:27 -0400 Date: Thu, 17 Mar 2016 11:25:14 +0000 From: Mark Brown To: "Pan, Harry" Cc: "lgirdwood@gmail.com" , "linux-kernel@vger.kernel.org" , "gs0622@gmail.com" , "alsa-devel@alsa-project.org" , "tiwai@suse.com" , "perex@perex.cz" Message-ID: <20160317112514.GE2566@sirena.org.uk> References: <1458127071-14417-1-git-send-email-harry.pan@intel.com> <20160317095438.GD2566@sirena.org.uk> <1458211115.965.13.camel@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QQyEkJ+v1X6lF3FS" Content-Disposition: inline In-Reply-To: <1458211115.965.13.camel@intel.com> X-Cookie: Walk softly and carry a megawatt laser. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1664 Lines: 41 --QQyEkJ+v1X6lF3FS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Mar 17, 2016 at 10:38:36AM +0000, Pan, Harry wrote: > Allow me to explain more detail that I saw during debug; since the > commit 6e78108bda78 (ASoC: core: Don't probe the component which is > dummy), an exception has been made that dummy component won't be probed, > thus the 'card' passed into soc_probe_component() would not be assigned > to this component. In the other hand, the component struct is initially > created in snd_soc_register_platform() by kzalloc() of platform struct, > its 'card' pointer is remaining an NULL pointer even the widget node > being read. > Perhaps another option is to refine soc_probe_component(), which I have > not dive in. Another approach might be to create a separate dummy component for each card rather than trying to reuse the same one for all of them (which was what the commit you mention was doing) - that way we don't need to worry about it getting added to multiple cards which was the original problem that was being looked at here. --QQyEkJ+v1X6lF3FS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJW6pQZAAoJECTWi3JdVIfQt/wH/iO1xD5ssPveBXHtNZG7b2WG Db3zmW9Nb+5oPAwdUZyUHWG7DOtLrsXw486ML4Y2+TjxO2zZIWUycHrZVyVAVFvn JYB8r2jjiD4/aLvYuogCpuhJKKHhd3teFkL5C0LcOv4qAVvIY+3Te7XpPly92DPx 5qX5rzZtsMrXPBSaOZYydRptiVS5Us1ZtcIqCtqUC4BseVgU9pHxvdut5MW47mB9 rLPUU4gACp9QqkBNN6sbgUKEgu5mpwvPRx/G5a5/XgHx9yBo67EHfU7+fMpCpgFT +WeVDaisZxz9bbR+6zzDRKlzcj4iYDXHSwvzcn/jzIw+BwsiAWMKgMBfffaCa2c= =ONYi -----END PGP SIGNATURE----- --QQyEkJ+v1X6lF3FS--