Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935829AbcCQL3T (ORCPT ); Thu, 17 Mar 2016 07:29:19 -0400 Received: from smtprelay2.synopsys.com ([198.182.60.111]:35836 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932920AbcCQL3R convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2016 07:29:17 -0400 From: Vineet Gupta To: Kefeng Wang , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" CC: "arnd@arndb.de" , "shawnguo@kernel.org" , "catalin.marinas@arm.com" , "linux@arm.linux.org.uk" , "robh+dt@kernel.org" , "grant.likely@linaro.org" , "olof@lixom.net" , "yamada.masahiro@socionext.com" , "guohanjun@huawei.com" , Vineet Gupta Subject: Re: [PATCH v2 all 04/14] arc: use of_platform_default_populate() to populate default bus Thread-Topic: [PATCH v2 all 04/14] arc: use of_platform_default_populate() to populate default bus Thread-Index: AQHRf1YiUQAScmEJ4EuB/Ik+uqzUOQ== Date: Thu, 17 Mar 2016 11:29:13 +0000 Message-ID: References: <1458113743-15131-1-git-send-email-wangkefeng.wang@huawei.com> <1458113743-15131-5-git-send-email-wangkefeng.wang@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.144.199.104] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1231 Lines: 34 On Wednesday 16 March 2016 01:03 PM, Kefeng Wang wrote: > Use helper of_platform_default_populate() in linux/of_platform > when possible, instead of calling of_platform_populate() with > the default match table. > > Acked-by: Vineet Gupta > Cc: Vineet Gupta > Signed-off-by: Kefeng Wang Thx Kefeng. I've added this to ARC for-curr for 4.6 > --- > arch/arc/kernel/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c > index cdc821d..401f51f 100644 > --- a/arch/arc/kernel/setup.c > +++ b/arch/arc/kernel/setup.c > @@ -464,7 +464,7 @@ static int __init customize_machine(void) > * Traverses flattened DeviceTree - registering platform devices > * (if any) complete with their resources > */ > - of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); > + of_platform_default_populate(NULL, NULL, NULL); Perhaps too late - but can't of_platform_default_populate just be a static inline calling of_platform_populate in the header rather than exporting yet another symbol ! -Vineet > > if (machine_desc->init_machine) > machine_desc->init_machine();