Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935726AbcCQLkl (ORCPT ); Thu, 17 Mar 2016 07:40:41 -0400 Received: from casper.infradead.org ([85.118.1.10]:57304 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752645AbcCQLkj (ORCPT ); Thu, 17 Mar 2016 07:40:39 -0400 Date: Thu, 17 Mar 2016 12:40:37 +0100 From: Peter Zijlstra To: Juri Lelli Cc: "Rafael J. Wysocki" , Linux PM list , Steve Muckle , ACPI Devel Maling List , Linux Kernel Mailing List , Srinivas Pandruvada , Viresh Kumar , Vincent Guittot , Michael Turquette , Ingo Molnar Subject: Re: [PATCH v5 6/7][Update] cpufreq: Support for fast frequency switching Message-ID: <20160317114037.GB6356@twins.programming.kicks-ass.net> References: <2495375.dFbdlAZmA6@vostro.rjw.lan> <4088601.C2vItRYpQn@vostro.rjw.lan> <1711281.bPmSjlBT7c@vostro.rjw.lan> <4785370.no59v8qjgi@vostro.rjw.lan> <20160317113507.GH18212@e106622-lin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160317113507.GH18212@e106622-lin> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 444 Lines: 11 On Thu, Mar 17, 2016 at 11:35:07AM +0000, Juri Lelli wrote: > > + pr_warn("cpufreq: CPU%u: Fast freqnency switching not enabled\n", > > Ultra-minor nit: s/freqnency/frequency/ > > Also, is this really a warning or just a debug message? (everything > seems to work fine on Juno even if this is printed :-)). I would consider it a warn; this _should_ not happen. If your platform supports fast_switch, then you really rather want to use it.