From: =?gb2312?B?xr3LydHFy8ggLyBISVJBTUFUVaOsTUFTQU1J?= 
	<masami.hiramatsu.pt@hitachi.com>
To: "'David Long'" <dave.long@linaro.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Sandeepa Prabhu <sandeepa.s.prabhu@gmail.com>,
        William Cohen <wcohen@redhat.com>,
        "Pratyush Anand" <panand@redhat.com>,
        Steve Capper <steve.capper@linaro.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Marc Zyngier <marc.zyngier@arm.com>
CC: Mark Rutland <mark.rutland@arm.com>, Petr Mladek <pmladek@suse.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        John Blackwood <john.blackwood@ccur.com>, Feng Kan <fkan@apm.com>,
        Zi Shen Lim <zlim.lnx@gmail.com>, Dave P Martin <Dave.Martin@arm.com>,
        Yang Shi <yang.shi@linaro.org>,
        Vladimir Murzin <Vladimir.Murzin@arm.com>,
        Kees Cook <keescook@chromium.org>,
        "Suzuki K. Poulose" <suzuki.poulose@arm.com>,
        "Mark Brown" <broonie@kernel.org>,
        =?gb2312?B?QWxleCBCZW5uqKZl?= <alex.bennee@linaro.org>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Mark Salyzyn <salyzyn@android.com>, James Morse <james.morse@arm.com>,
        Christoffer Dall <christoffer.dall@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Robin Murphy <Robin.Murphy@arm.com>,
        Jens Wiklander <jens.wiklander@linaro.org>,
        Balamurugan Shanmugam <bshanmugam@apm.com>,
        sysp-manager <cti.systems-productivity-manager.ts@hitachi.com>
Subject: RE: [PATCH v11 3/9] arm64: add copy_to/from_user to kprobes
 blacklist
Thread-Topic: [!][PATCH v11 3/9] arm64: add copy_to/from_user to kprobes
 blacklist
Thread-Index: AQHRecVBKxJWiebga02QNWs4y5chfZ9dlnLg
Date: Thu, 17 Mar 2016 12:04:30 +0000
Message-ID: <50399556C9727B4D88A595C8584AAB37B4E50343@GSjpTKYDCembx32.service.hitachi.net>
References: <1457501543-24197-1-git-send-email-dave.long@linaro.org>
 <1457501543-24197-4-git-send-email-dave.long@linaro.org>
In-Reply-To: <1457501543-24197-4-git-send-email-dave.long@linaro.org>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
Content-Type: text/plain; charset="gb2312"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1454
Lines: 51

>From: "David A. Long" <dave.long@linaro.org>
>
>Currrently taking exceptions when accessing user data from a kprobe'd
>instruction doesn't work. Avoid this situation by blacklisting the relevant
>functions.
>
>Signed-off-by: David A. Long <dave.long@linaro.org>

Looks good to me.

Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thanks,

>---
> arch/arm64/lib/copy_from_user.S | 1 +
> arch/arm64/lib/copy_to_user.S   | 1 +
> 2 files changed, 2 insertions(+)
>
>diff --git a/arch/arm64/lib/copy_from_user.S b/arch/arm64/lib/copy_from_user.S
>index 4699cd7..0ac2131 100644
>--- a/arch/arm64/lib/copy_from_user.S
>+++ b/arch/arm64/lib/copy_from_user.S
>@@ -66,6 +66,7 @@
> 	.endm
>
> end	.req	x5
>+	.section .kprobes.text,"ax",%progbits
> ENTRY(__copy_from_user)
> ALTERNATIVE("nop", __stringify(SET_PSTATE_PAN(0)), ARM64_HAS_PAN, \
> 	    CONFIG_ARM64_PAN)
>diff --git a/arch/arm64/lib/copy_to_user.S b/arch/arm64/lib/copy_to_user.S
>index 7512bbb..e4eb84c 100644
>--- a/arch/arm64/lib/copy_to_user.S
>+++ b/arch/arm64/lib/copy_to_user.S
>@@ -65,6 +65,7 @@
> 	.endm
>
> end	.req	x5
>+	.section .kprobes.text,"ax",%progbits
> ENTRY(__copy_to_user)
> ALTERNATIVE("nop", __stringify(SET_PSTATE_PAN(0)), ARM64_HAS_PAN, \
> 	    CONFIG_ARM64_PAN)
>--
>2.5.0
>
>
>_______________________________________________
>linux-arm-kernel mailing list
>linux-arm-kernel@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel