Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030560AbcCQMQT (ORCPT ); Thu, 17 Mar 2016 08:16:19 -0400 Received: from smtprelay.synopsys.com ([198.182.60.111]:36539 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030411AbcCQMQR convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2016 08:16:17 -0400 From: Vineet Gupta To: Sergei Shtylyov , Alexey Brodkin CC: "robh@kernel.org" , "preid@electromag.com.au" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "davem@davemloft.net" Subject: Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Thread-Topic: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Thread-Index: AQHRgDFXNOSRRka9PESGJ+Dm4Wx28Q== Date: Thu, 17 Mar 2016 12:16:15 +0000 Message-ID: References: <1458207712-29435-1-git-send-email-abrodkin@synopsys.com> <56EA8DCC.8070308@cogentembedded.com> <1458214678.14496.15.camel@synopsys.com> <56EA9C0D.1090000@cogentembedded.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.144.199.104] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1266 Lines: 40 On Thursday 17 March 2016 05:29 PM, Sergei Shtylyov wrote: > Hello. > > On 3/17/2016 2:41 PM, Vineet Gupta wrote: > >>>>> >>>> Following commit broke DW GMAC functionality on AXS10x boards: >>>>> >>>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763 >>>> >>> Note that scripts/checkpatch.pl now enforces certain format for citing >>>> >>> commits: commit <12-digit SHA1> (""). >>> >> Frankly I haven't run that patch through checkpatch due to patch >>> >> simplicity. >>> >> >>> >> But I'll try to not do any assumptions from now on and will try to >>> >> use checkpatch for each and every thing I send :) >>> >> >>> >> Thanks for spotting all his! >>> >> > Sorry for not reporting everything on the 1st review. > >>> >> -Alexey >> > >> > Sergei, do you mind providing a Ack/Reviewed-by on the patch below > > > > Reviewed-by: Sergei Shtylyov Thx. > The patch here is white space damaged however: tabs were converted to > spaces. :-( > > MBR, Sergei That was just because of copy-paste into mailer before switching to plain-text. Don't ask - corporate email ! I added it just to give u an idea of what fixup i did. Tx, -Vineet