Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936061AbcCQNAu (ORCPT ); Thu, 17 Mar 2016 09:00:50 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:33759 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933267AbcCQNAr (ORCPT ); Thu, 17 Mar 2016 09:00:47 -0400 MIME-Version: 1.0 In-Reply-To: <20160317080926.GO1793@lahna.fi.intel.com> References: <1458174199-23615-1-git-send-email-ddaney.cavm@gmail.com> <20160317080926.GO1793@lahna.fi.intel.com> Date: Thu, 17 Mar 2016 14:00:46 +0100 X-Google-Sender-Auth: SFjFVIbEr0gQUWhI4eLH0b2vULI Message-ID: Subject: Re: [PATCH] ACPI / property: Export a couple of symbols. From: "Rafael J. Wysocki" To: Mika Westerberg , David Daney Cc: "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Linux Kernel Mailing List , Robert Richter , Tomasz Nowicki , David Daney Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 764 Lines: 18 On Thu, Mar 17, 2016 at 9:09 AM, Mika Westerberg wrote: > On Wed, Mar 16, 2016 at 05:23:19PM -0700, David Daney wrote: >> From: David Daney >> >> The acpi_dev_prop_read() and acpi_dev_prop_read_single() can be called >> by drivers. Add EXPORT_SYMBOL_GPL to them to allow use by modular >> drivers. This makes them consistent with acpi_dev_get_property() and >> acpi_node_get_property_reference() which are already exported. >> >> Signed-off-by: David Daney >> --- >> FWIW: We hope to submit soon Cavium Thunder networking patches that >> fail under modular builds without these exports. > > You should not be using these functions directly in drivers. That's exactly my point.