Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936089AbcCQN2r (ORCPT ); Thu, 17 Mar 2016 09:28:47 -0400 Received: from mail.kernel.org ([198.145.29.136]:45513 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932614AbcCQN2m (ORCPT ); Thu, 17 Mar 2016 09:28:42 -0400 MIME-Version: 1.0 In-Reply-To: References: <1458113743-15131-1-git-send-email-wangkefeng.wang@huawei.com> <1458113743-15131-5-git-send-email-wangkefeng.wang@huawei.com> From: Rob Herring Date: Thu, 17 Mar 2016 08:28:18 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 all 04/14] arc: use of_platform_default_populate() to populate default bus To: Vineet Gupta Cc: Kefeng Wang , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arnd@arndb.de" , "shawnguo@kernel.org" , "catalin.marinas@arm.com" , "linux@arm.linux.org.uk" , "grant.likely@linaro.org" , "olof@lixom.net" , "yamada.masahiro@socionext.com" , "guohanjun@huawei.com" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 35 On Thu, Mar 17, 2016 at 6:29 AM, Vineet Gupta wrote: > On Wednesday 16 March 2016 01:03 PM, Kefeng Wang wrote: >> Use helper of_platform_default_populate() in linux/of_platform >> when possible, instead of calling of_platform_populate() with >> the default match table. >> >> Acked-by: Vineet Gupta >> Cc: Vineet Gupta >> Signed-off-by: Kefeng Wang > > Thx Kefeng. I've added this to ARC for-curr for 4.6 > >> --- >> arch/arc/kernel/setup.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c >> index cdc821d..401f51f 100644 >> --- a/arch/arc/kernel/setup.c >> +++ b/arch/arc/kernel/setup.c >> @@ -464,7 +464,7 @@ static int __init customize_machine(void) >> * Traverses flattened DeviceTree - registering platform devices >> * (if any) complete with their resources >> */ >> - of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); >> + of_platform_default_populate(NULL, NULL, NULL); > > Perhaps too late - but can't of_platform_default_populate just be a static inline > calling of_platform_populate in the header rather than exporting yet another symbol ! The idea is to not export the variable of_default_bus_match_table and export a function instead. Rob