Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967092AbcCQOTP (ORCPT ); Thu, 17 Mar 2016 10:19:15 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:38479 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966264AbcCQOTJ convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2016 10:19:09 -0400 From: Vineet Gupta To: Rob Herring CC: Kefeng Wang , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arnd@arndb.de" , "shawnguo@kernel.org" , "catalin.marinas@arm.com" , "linux@arm.linux.org.uk" , "grant.likely@linaro.org" , "olof@lixom.net" , "yamada.masahiro@socionext.com" , "guohanjun@huawei.com" Subject: Re: [PATCH v2 all 04/14] arc: use of_platform_default_populate() to populate default bus Thread-Topic: [PATCH v2 all 04/14] arc: use of_platform_default_populate() to populate default bus Thread-Index: AQHRf1YiUQAScmEJ4EuB/Ik+uqzUOQ== Date: Thu, 17 Mar 2016 14:19:06 +0000 Message-ID: References: <1458113743-15131-1-git-send-email-wangkefeng.wang@huawei.com> <1458113743-15131-5-git-send-email-wangkefeng.wang@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.144.199.104] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 648 Lines: 16 On Thursday 17 March 2016 06:58 PM, Rob Herring wrote: >> Perhaps too late - but can't of_platform_default_populate just be a static inline >> > calling of_platform_populate in the header rather than exporting yet another symbol ! > The idea is to not export the variable of_default_bus_match_table and > export a function instead. > > Rob Yep I realized this after reading the cover letter of patch which I didn't get ! BTW since I got your attention, could u please take a look at http://lists.infradead.org/pipermail/linux-snps-arc/2016-March/000653.html and http://lists.infradead.org/pipermail/linux-snps-arc/2016-March/000656.html -Vineet