Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030770AbcCQOlF (ORCPT ); Thu, 17 Mar 2016 10:41:05 -0400 Received: from mail.kernel.org ([198.145.29.136]:53901 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935230AbcCQOlC (ORCPT ); Thu, 17 Mar 2016 10:41:02 -0400 MIME-Version: 1.0 In-Reply-To: References: <1458113743-15131-1-git-send-email-wangkefeng.wang@huawei.com> <1458113743-15131-5-git-send-email-wangkefeng.wang@huawei.com> From: Rob Herring Date: Thu, 17 Mar 2016 09:40:37 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 all 04/14] arc: use of_platform_default_populate() to populate default bus To: Vineet Gupta Cc: Kefeng Wang , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arnd@arndb.de" , "shawnguo@kernel.org" , "catalin.marinas@arm.com" , "linux@arm.linux.org.uk" , "grant.likely@linaro.org" , "olof@lixom.net" , "yamada.masahiro@socionext.com" , "guohanjun@huawei.com" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 853 Lines: 21 On Thu, Mar 17, 2016 at 9:19 AM, Vineet Gupta wrote: > On Thursday 17 March 2016 06:58 PM, Rob Herring wrote: >>> Perhaps too late - but can't of_platform_default_populate just be a static inline >>> > calling of_platform_populate in the header rather than exporting yet another symbol ! >> The idea is to not export the variable of_default_bus_match_table and >> export a function instead. >> >> Rob > > Yep I realized this after reading the cover letter of patch which I didn't get ! > > BTW since I got your attention, could u please take a look at > http://lists.infradead.org/pipermail/linux-snps-arc/2016-March/000653.html > and > http://lists.infradead.org/pipermail/linux-snps-arc/2016-March/000656.html If it is in DT patchworks, I'll get to it soon. I'm about 2 weeks behind between conference and vacation. Rob