Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967324AbcCQPDO (ORCPT ); Thu, 17 Mar 2016 11:03:14 -0400 Received: from mail.kernel.org ([198.145.29.136]:56434 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932876AbcCQPDL (ORCPT ); Thu, 17 Mar 2016 11:03:11 -0400 Date: Thu, 17 Mar 2016 10:03:05 -0500 From: Rob Herring To: Franklin S Cooper Jr Cc: thierry.reding@gmail.com, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, bcousson@baylibre.com, tony@atomide.com, linux@arm.linux.org.uk, t-kristo@ti.com, mturquette@baylibre.com, sboyd@codeaurora.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 5/5] pwm: pwm-tiehrpwm: Update dt binding document to use generic node name Message-ID: <20160317150305.GA27356@rob-hp-laptop> References: <1457380318-15452-1-git-send-email-fcooper@ti.com> <1457380318-15452-6-git-send-email-fcooper@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457380318-15452-6-git-send-email-fcooper@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1321 Lines: 37 On Mon, Mar 07, 2016 at 01:51:58PM -0600, Franklin S Cooper Jr wrote: > Now that the node name has been changed from ehrpwm to pwm the document > should show this proper usage. Also change the unit address in the example > from 0 to the proper physical address value that should be used. > > Signed-off-by: Franklin S Cooper Jr > --- > Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt > index 9c100b2..20211ed 100644 > --- a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt > +++ b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt > @@ -15,14 +15,14 @@ Optional properties: > > Example: > > -ehrpwm0: ehrpwm@0 { /* EHRPWM on am33xx */ > +ehrpwm0: pwm@48300200 { /* EHRPWM on am33xx */ > compatible = "ti,am33xx-ehrpwm"; > #pwm-cells = <3>; > reg = <0x48300200 0x100>; > ti,hwmods = "ehrpwm0"; > }; > > -ehrpwm0: ehrpwm@0 { /* EHRPWM on da850 */ > +ehrpwm0: pwm@01f00000 { /* EHRPWM on da850 */ No leading 0s, but more importantly the address is wrong. > compatible = "ti,da850-ehrpwm", "ti,am33xx-ehrpwm"; > #pwm-cells = <3>; > reg = <0x300000 0x2000>; > -- > 2.7.0 >