Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031348AbcCQQjz (ORCPT ); Thu, 17 Mar 2016 12:39:55 -0400 Received: from mga09.intel.com ([134.134.136.24]:55737 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030692AbcCQQjt (ORCPT ); Thu, 17 Mar 2016 12:39:49 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,350,1455004800"; d="scan'208";a="939497711" Date: Thu, 17 Mar 2016 16:39:46 +0000 From: Keith Busch To: Vitaly Kuznetsov Cc: Ming Lei , linux-block@vger.kernel.org, Linux Kernel Mailing List , Jens Axboe , Dan Williams , "Martin K. Petersen" , Sagi Grimberg , Mike Snitzer , "K. Y. Srinivasan" , Cathy Avery Subject: Re: [PATCH RFC] block: fix bio merge checks when virt_boundary is set Message-ID: <20160317163946.GC6217@localhost.lm.intel.com> References: <1458055076-2175-1-git-send-email-vkuznets@redhat.com> <87oaae4cej.fsf@vitty.brq.redhat.com> <20160316223804.GA6217@localhost.lm.intel.com> <87egb94agz.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87egb94agz.fsf@vitty.brq.redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 656 Lines: 17 On Thu, Mar 17, 2016 at 12:20:28PM +0100, Vitaly Kuznetsov wrote: > Keith Busch writes: > > been combined. In any case, I think you can get what you're after just > > by moving the gap check after BIOVEC_PHYS_MERGABLE. Does the following > > look ok to you? > > > > Thanks, it does. Cool, thanks for confirming. > Will you send it or would you like me to do that with your Suggested-by? I'm not confident yet this doesn't break anything, particularly since we moved the gap check after the length check. Just wanted to confirm the concept addressed your concern, but still need to take a closer look and test before submitting.