Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936269AbcCQQnI (ORCPT ); Thu, 17 Mar 2016 12:43:08 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:33757 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936159AbcCQQnG convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2016 12:43:06 -0400 From: Laurent Pinchart To: Sebastian Reichel Cc: Tony Lindgren , Aaro Koskinen , Tomi Valkeinen , David Airlie , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/23] ARM: dts: n950: add display support Date: Thu, 17 Mar 2016 14:14:26 +0200 Message-ID: <21766689.NesyW3QHk4@avalon> User-Agent: KMail/4.14.8 (Linux/4.1.15-gentoo-r1; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1457455195-1938-3-git-send-email-sre@kernel.org> References: <1457455195-1938-1-git-send-email-sre@kernel.org> <1457455195-1938-3-git-send-email-sre@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2630 Lines: 112 Hi Sebastian, Thank you for the patch. On Tuesday 08 March 2016 17:39:34 Sebastian Reichel wrote: > Signed-off-By: Sebastian Reichel > --- > arch/arm/boot/dts/omap3-n950.dts | 71 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/arch/arm/boot/dts/omap3-n950.dts > b/arch/arm/boot/dts/omap3-n950.dts index 0885b34d5d7d..41b8fb585272 100644 > --- a/arch/arm/boot/dts/omap3-n950.dts > +++ b/arch/arm/boot/dts/omap3-n950.dts > @@ -17,6 +17,26 @@ > compatible = "nokia,omap3-n950", "ti,omap36xx", "ti,omap3"; > }; > > +&omap3_pmx_core { > + dsi_pins: pinmux_dsi_pins { > + pinctrl-single,pins = < > + OMAP3_CORE1_IOPAD(0x20dc, PIN_OUTPUT | MUX_MODE1) /* dsi_dx0 - > data0+ */ > + OMAP3_CORE1_IOPAD(0x20de, PIN_OUTPUT | MUX_MODE1) /* dsi_dy0 - > data0- */ > + OMAP3_CORE1_IOPAD(0x20e0, PIN_OUTPUT | MUX_MODE1) /* dsi_dx1 - > clk+ */ > + OMAP3_CORE1_IOPAD(0x20e2, PIN_OUTPUT | MUX_MODE1) /* dsi_dy1 - > clk- */ > + OMAP3_CORE1_IOPAD(0x20e4, PIN_OUTPUT | MUX_MODE1) /* dsi_dx2 - > data1+ */ > + OMAP3_CORE1_IOPAD(0x20e6, PIN_OUTPUT | MUX_MODE1) /* dsi_dy2 - > data1- */ > + >; > + }; > + > + display_pins: pinmux_display_pins { > + pinctrl-single,pins = < > + OMAP3_CORE1_IOPAD(0x20ca, PIN_INPUT | MUX_MODE4) /* gpio 62 - > display te */ > + OMAP3_CORE1_IOPAD(0x20fe, PIN_OUTPUT | MUX_MODE4) /* gpio 87 - > display reset */ > + >; > + }; > +}; > + > &i2c2 { > smia_1: camera@10 { > compatible = "nokia,smia"; > @@ -53,3 +73,54 @@ > }; > }; > }; > + > +&dss { > + status = "ok"; > + > + vdda_video-supply = <&vdac>; > +}; > + > +&dsi { > + status = "ok"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&dsi_pins>; > + > + vdd-supply = <&vpll2>; > + > + port { > + dsi_out_ep: endpoint { > + remote-endpoint = <&lcd0_in>; > + lanes = <2 3 0 1 4 5>; > + }; > + }; > + > + lcd0: display { > + compatible = "nokia,himalaya", "panel-dsi-cm"; > + label = "lcd0"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&display_pins>; > + > + vpnl-supply = <&vmmc2>; > + vddi-supply = <&vio>; > + > + reset-gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>; /* 87 */ > + te-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>; /* 62 */ > + > + has-dsi-backlight; > + > + /* panel is 480x464 with top and bottom 5 lines not visible */ I assume you mean 480x864 ? > + /* physical dimensions: 48960?m x 88128?m */ > + resolution-x = <480>; > + resolution-y = <854>; > + offset-x = <0>; > + offset-y = <5>; > + > + port { > + lcd0_in: endpoint { > + remote-endpoint = <&dsi_out_ep>; > + }; > + }; > + }; > +}; -- Regards, Laurent Pinchart