Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031493AbcCQQoO (ORCPT ); Thu, 17 Mar 2016 12:44:14 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:33894 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031470AbcCQQoK (ORCPT ); Thu, 17 Mar 2016 12:44:10 -0400 From: Laurent Pinchart To: Kedareswara rao Appana Cc: dan.j.williams@intel.com, vinod.koul@intel.com, michal.simek@xilinx.com, soren.brinkmann@xilinx.com, appanad@xilinx.com, moritz.fischer@ettus.com, luis@debethencourt.com, anirudh@xilinx.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] dmaengine: xilinx_vdma: Fix checkpatch.pl warnings Date: Thu, 17 Mar 2016 09:00:14 +0200 Message-ID: <1583818.aXla9CoXzO@avalon> User-Agent: KMail/4.14.8 (Linux/4.1.15-gentoo-r1; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1458062592-27981-2-git-send-email-appanad@xilinx.com> References: <1458062592-27981-1-git-send-email-appanad@xilinx.com> <1458062592-27981-2-git-send-email-appanad@xilinx.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1585 Lines: 60 Hello, On Tuesday 15 March 2016 22:53:06 Kedareswara rao Appana wrote: > This patch fixes the below checkpatch.pl warnings. > > WARNING: void function return statements are not generally useful > + return; > +} > > WARNING: void function return statements are not generally useful > + return; > +} > > WARNING: Missing a blank line after declarations > + u32 errors = status & XILINX_VDMA_DMASR_ALL_ERR_MASK; > + vdma_ctrl_write(chan, XILINX_VDMA_REG_DMASR, > > Signed-off-by: Kedareswara rao Appana Acked-by: Laurent Pinchart > --- > drivers/dma/xilinx/xilinx_vdma.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/dma/xilinx/xilinx_vdma.c > b/drivers/dma/xilinx/xilinx_vdma.c index 0ee0321..7ab6793 100644 > --- a/drivers/dma/xilinx/xilinx_vdma.c > +++ b/drivers/dma/xilinx/xilinx_vdma.c > @@ -569,8 +569,6 @@ static void xilinx_vdma_halt(struct xilinx_vdma_chan > *chan) chan, vdma_ctrl_read(chan, XILINX_VDMA_REG_DMASR)); > chan->err = true; > } > - > - return; > } > > /** > @@ -595,8 +593,6 @@ static void xilinx_vdma_start(struct xilinx_vdma_chan > *chan) > > chan->err = true; > } > - > - return; > } > > /** > @@ -829,6 +825,7 @@ static irqreturn_t xilinx_vdma_irq_handler(int irq, void > *data) * make sure not to write to other error bits to 1. > */ > u32 errors = status & XILINX_VDMA_DMASR_ALL_ERR_MASK; > + > vdma_ctrl_write(chan, XILINX_VDMA_REG_DMASR, > errors & XILINX_VDMA_DMASR_ERR_RECOVER_MASK); -- Regards, Laurent Pinchart