Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031524AbcCQQod (ORCPT ); Thu, 17 Mar 2016 12:44:33 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:33895 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031470AbcCQQoP (ORCPT ); Thu, 17 Mar 2016 12:44:15 -0400 From: Laurent Pinchart To: Kuninori Morimoto Cc: Geert Uytterhoeven , Linus Walleij , Magnus , Simon , linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] pinctrl: sh-pfc: IPSRx and MOD_SELx should be set before GPSRx Date: Thu, 17 Mar 2016 08:58:45 +0200 Message-ID: <1532372.pY3qGGVVN1@avalon> User-Agent: KMail/4.14.8 (Linux/4.1.15-gentoo-r1; KDE/4.14.8; x86_64; ; ) In-Reply-To: <8737rrfe1f.wl%kuninori.morimoto.gx@renesas.com> References: <8760wnfe3r.wl%kuninori.morimoto.gx@renesas.com> <8737rrfe1f.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1272 Lines: 41 Hi Morimoto-san, Thank you for the patch. On Wednesday 16 March 2016 00:48:11 Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Gen2 / Gen3 datasheet will have below note in next version. > This patch follows this note. > > IPSRx and MOD_SELx registers shall be set before setting GPSRx > registers in case that they need to be configured. > MOD_SELx registers can be set either earlier or later than setting > IPSRx registers. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart > --- > drivers/pinctrl/sh-pfc/sh_pfc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h > b/drivers/pinctrl/sh-pfc/sh_pfc.h index 2b593fc..f174d61 100644 > --- a/drivers/pinctrl/sh-pfc/sh_pfc.h > +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h > @@ -279,7 +279,7 @@ struct sh_pfc_soc_info { > * - msel: Module selector > */ > #define PINMUX_IPSR_MSEL(ipsr, fn, msel) \ > - PINMUX_DATA(fn##_MARK, FN_##msel, FN_##ipsr, FN_##fn) > + PINMUX_DATA(fn##_MARK, FN_##msel, FN_##fn, FN_##ipsr) > > /* > * Describe a pinmux configuration for a single-function pin with GPIO -- Regards, Laurent Pinchart