Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031626AbcCQQ7Q (ORCPT ); Thu, 17 Mar 2016 12:59:16 -0400 Received: from mail-bn1on0136.outbound.protection.outlook.com ([157.56.110.136]:23568 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935821AbcCQQ7N convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2016 12:59:13 -0400 From: Hartley Sweeten To: Arnd Bergmann CC: Ian Abbott , Greg Kroah-Hartman , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2] staging/comedi/dt282x: avoid integer overflow warning Thread-Topic: [PATCH v2] staging/comedi/dt282x: avoid integer overflow warning Thread-Index: AQHRf8Wrp8TTHLyDSEGX7TkInjYrEp9dxbXggAAJQgCAAApK0A== Date: Thu, 17 Mar 2016 16:59:10 +0000 Message-ID: References: <1458161501-283680-1-git-send-email-arnd@arndb.de> <3053856.pfRJflhkJ8@wuerfel> In-Reply-To: <3053856.pfRJflhkJ8@wuerfel> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=none action=none header.from=visionengravers.com; x-originating-ip: [184.183.19.121] x-ms-office365-filtering-correlation-id: b1383160-076b-4499-f50e-08d34e8575d6 x-microsoft-exchange-diagnostics: 1;BN3PR0101MB1059;5:jj42Mb/tTFH4fNuR90RTCfREeqQKZHk4L8g/IOocswm2/BjY6Q1e7uqmEeS3OgoJcXBkGYdLeYgoof7f6uxzOCerTgAAFSlsVUiLya2JuA/fePJMQCm3XM7aJKTxoQMyt5BEA/uHYyDkJvdIRCQH4g==;24:C4GIibrInXt3jS13FiC7Z7g09Pcksd4Te2CmOYOKYbfloWLGEado0LAuvQ4luPdrEJfZLTX8ebPtl+yyQSwqmYzCldJLmWsqFIzLwUloIJM= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0101MB1059; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040046)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041046)(6043046);SRVR:BN3PR0101MB1059;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0101MB1059; x-forefront-prvs: 0884AAA693 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(164054003)(24454002)(377454003)(52044002)(92566002)(77096005)(122556002)(2950100001)(2900100001)(106116001)(74316001)(3660700001)(5002640100001)(2906002)(86362001)(33656002)(5003600100002)(81166005)(5008740100001)(11100500001)(66066001)(1220700001)(50986999)(87936001)(3280700002)(110136002)(4326007)(6116002)(76176999)(3846002)(54356999)(5004730100002)(102836003)(586003)(1096002)(189998001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0101MB1059;H:BN3PR0101MB1057.prod.exchangelabs.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2016 16:59:10.1588 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0101MB1059 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 795 Lines: 23 On Thursday, March 17, 2016 9:09 AM, Arnd Bergmann wrote: > On Thursday 17 March 2016 15:47:57 Hartley Sweeten wrote: >> On Wednesday, March 16, 2016 1:51 PM, Arnd Bergmann wrote: >> >> Is this a gcc-6 specific issue? Seems line this warning should be showing >> up in a lot of drivers. > > Yes, I did not see this before moving to gcc-6.0, but this is the only driver > I've encountered the warning for, in around 7000 randconfig builds. Weird... > Feel free to come up with a different patch. I've put the patch on > my 'submitted' stack for now and will get back to it after 4.7-rc1 if > the warning remains. I'll post an alternate patch shortly that is more consistent with the other comedi drivers. If you could test that it fixes the gcc-6 issue that would be great! Thanks, Hartley