Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031703AbcCQRBd (ORCPT ); Thu, 17 Mar 2016 13:01:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:48624 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031681AbcCQRBa (ORCPT ); Thu, 17 Mar 2016 13:01:30 -0400 From: Alexander Graf To: linux-s390@vger.kernel.org Cc: Eugene Crosser , linux-kernel@vger.kernel.org, Heiko Carstens , Martin Schwidefsky , Ursula Braun , ihno@suse.de, mt@suse.com, pwieczorkiewicz@suse.de Subject: [PATCH] qeth: Default to allow promiscuous mode Date: Thu, 17 Mar 2016 18:01:25 +0100 Message-Id: <1458234085-217667-1-git-send-email-agraf@suse.de> X-Mailer: git-send-email 1.8.5.6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 33 When a qeth device is in bridge role, one of the ports of an adapter can ask for promiscuous mode and get it enabled. The default until now was to not allow user space to enable promiscuous mode without switching sysfs attributes as well though, diverging from usual network device semantics. This patch sets the default to allow promiscuous enablement. That way all existing tools "just work", albeit only one port of an adapter can be in promiscuous mode at a given time. Signed-off-by: Alexander Graf --- drivers/s390/net/qeth_l2_sys.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/s390/net/qeth_l2_sys.c b/drivers/s390/net/qeth_l2_sys.c index 692db49..98c7ac5 100644 --- a/drivers/s390/net/qeth_l2_sys.c +++ b/drivers/s390/net/qeth_l2_sys.c @@ -258,6 +258,10 @@ void qeth_l2_setup_bridgeport_attrs(struct qeth_card *card) return; if (!card->options.sbp.supported_funcs) return; + + /* Allow to set promiscuous by default */ + card->options.sbp.reflect_promisc = 1; + if (card->options.sbp.role != QETH_SBP_ROLE_NONE) { /* Conditional to avoid spurious error messages */ qeth_bridgeport_setrole(card, card->options.sbp.role); -- 1.8.5.6