Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935992AbcCQRP2 (ORCPT ); Thu, 17 Mar 2016 13:15:28 -0400 Received: from mail.kernel.org ([198.145.29.136]:40171 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967208AbcCQRPM (ORCPT ); Thu, 17 Mar 2016 13:15:12 -0400 Date: Thu, 17 Mar 2016 12:15:07 -0500 From: Rob Herring To: Neil Armstrong Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, devicetree@vger.kernel.org Subject: Re: [PATCH v2 04/18] dt-bindings: irq: arm,versatile-fpga: add arm,rps-irq compatible string Message-ID: <20160317171507.GA31679@rob-hp-laptop> References: <1457005210-18485-1-git-send-email-narmstrong@baylibre.com> <1457519060-6038-1-git-send-email-narmstrong@baylibre.com> <1457519060-6038-5-git-send-email-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457519060-6038-5-git-send-email-narmstrong@baylibre.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 25 On Wed, Mar 09, 2016 at 11:24:06AM +0100, Neil Armstrong wrote: > Under the OX810SE, this same controller is used as "Reference Peripheral > Specification" Interrupt Controller, so add new compatible string. > > Signed-off-by: Neil Armstrong > --- > .../devicetree/bindings/interrupt-controller/arm,versatile-fpga-irq.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,versatile-fpga-irq.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,versatile-fpga-irq.txt > index c9cf605..2fe78d5 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/arm,versatile-fpga-irq.txt > +++ b/Documentation/devicetree/bindings/interrupt-controller/arm,versatile-fpga-irq.txt > @@ -6,7 +6,7 @@ controllers are OR:ed together and fed to the CPU tile's IRQ input. Each > instance can handle up to 32 interrupts. > > Required properties: > -- compatible: "arm,versatile-fpga-irq" > +- compatible: "arm,versatile-fpga-irq" or "arm,rps-irq" Use a compatible string that reflects the actual implementation not a spec. The current string is a bad example as it already refers to multiple implementations. Rob