Message-ID: <1458236486.9556.11.camel@perches.com>
Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr()
From: Joe Perches <joe@perches.com>
To: Gustavo Padovan <gustavo@padovan.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        dri-devel@lists.freedesktop.org, Daniel Stone <daniels@collabora.com>,
        Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= <arve@android.com>,
        Riley Andrews <riandrews@android.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Rob Clark <robdclark@gmail.com>, Greg Hackmann <ghackmann@google.com>,
        John Harrison <John.C.Harrison@Intel.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        akpm@linux-foundation.org, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel.vetter@Intel.com>
Date: Thu, 17 Mar 2016 10:41:26 -0700
In-Reply-To: <1458235817-28375-2-git-send-email-gustavo@padovan.org>
References: <1458235817-28375-1-git-send-email-gustavo@padovan.org>
	 <1458235817-28375-2-git-send-email-gustavo@padovan.org>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 585
Lines: 19

On Thu, 2016-03-17 at 14:30 -0300, Gustavo Padovan wrote:
> This function had copies in 3 different files. Unify them in
> kernel.h.

This is only used by gpu/drm.

I think this is a poor name for a generic function
that would be in kernel.h.

Isn't there an include file in linux/drm that's
appropriate for this. ?Maybe drmP.h

Maybe prefix this function name with drm_ too.

Also, there's this that might conflict:

arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p)??????????ptr_to_compat(p)
arch/powerpc/kernel/signal_32.c:#define to_user_ptr(p)??????????((unsigned long)(p))