Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936121AbcCQSGQ (ORCPT ); Thu, 17 Mar 2016 14:06:16 -0400 Received: from foss.arm.com ([217.140.101.70]:50106 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932829AbcCQSGN (ORCPT ); Thu, 17 Mar 2016 14:06:13 -0400 Subject: Re: [PATCH v2 02/18] dt-bindings: timer: sp804: add timer-width property To: Rob Herring , Neil Armstrong References: <1457005210-18485-1-git-send-email-narmstrong@baylibre.com> <1457519060-6038-1-git-send-email-narmstrong@baylibre.com> <1457519060-6038-3-git-send-email-narmstrong@baylibre.com> <20160317170926.GA28934@rob-hp-laptop> Cc: devicetree@vger.kernel.org, daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org, sudeep.holla@arm.com, rmk+kernel@arm.linux.org.uk, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org From: Robin Murphy Message-ID: <56EAF212.7020700@arm.com> Date: Thu, 17 Mar 2016 18:06:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160317170926.GA28934@rob-hp-laptop> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1818 Lines: 46 Hi Rob, On 17/03/16 17:09, Rob Herring wrote: > On Wed, Mar 09, 2016 at 11:24:04AM +0100, Neil Armstrong wrote: >> Add timer-width optional property to specify a different vendor >> specific timer counter bit-width. >> >> Signed-off-by: Neil Armstrong >> --- >> Documentation/devicetree/bindings/timer/arm,sp804.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/timer/arm,sp804.txt b/Documentation/devicetree/bindings/timer/arm,sp804.txt >> index 5cd8eee7..141e143 100644 >> --- a/Documentation/devicetree/bindings/timer/arm,sp804.txt >> +++ b/Documentation/devicetree/bindings/timer/arm,sp804.txt >> @@ -17,6 +17,8 @@ Optional properties: >> - arm,sp804-has-irq = <#>: In the case of only 1 timer irq line connected, this >> specifies if the irq connection is for timer 1 or timer 2. A value of 1 >> or 2 should be used. >> +- arm,timer-width: Should contain the width in number of bits of the counter, >> + is considered by default 32 but can be changed for vendor variants. > > That would not be an SP804 nor would the vendor be ARM in that case. So > add a new compatible string for the vendor that decided to hack up ARM's > IP block. By all accounts this is some ancient reference design[1] which later evolved _into_ the SP804, so that vendor would probably still be ARM ;) A separate compatible string would indeed make more sense, though. Both semantically and in terms of letting the driver account for the differences automatically. Robin. [1]:http://infocenter.arm.com/help/topic/com.arm.doc.ddi0170a/I350250.html > > Rob > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >