Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031248AbcCQTEc (ORCPT ); Thu, 17 Mar 2016 15:04:32 -0400 Received: from mail.kernel.org ([198.145.29.136]:47837 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936162AbcCQTEa (ORCPT ); Thu, 17 Mar 2016 15:04:30 -0400 MIME-Version: 1.0 In-Reply-To: <56EAD137.1080502@ti.com> References: <1457400224-24797-1-git-send-email-fcooper@ti.com> <1457400224-24797-4-git-send-email-fcooper@ti.com> <20160317150619.GA28105@rob-hp-laptop> <56EAD137.1080502@ti.com> From: Rob Herring Date: Thu, 17 Mar 2016 14:04:07 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 3/6] ARM: AM335x/AM437x: hwmod: Remove eQEP, ePWM and eCAP hwmod entries To: "Franklin S Cooper Jr." Cc: Thierry Reding , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Benoit Cousson , Tony Lindgren , Russell King - ARM Linux , "paul@pwsan.com" , Linux PWM List , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-omap , "linux-arm-kernel@lists.infradead.org" , Vignesh R Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 946 Lines: 26 On Thu, Mar 17, 2016 at 10:45 AM, Franklin S Cooper Jr. wrote: > > > On 03/17/2016 10:06 AM, Rob Herring wrote: >> On Mon, Mar 07, 2016 at 07:23:41PM -0600, Franklin S Cooper Jr wrote: >>> Devices that utilize the OCP registers and/or PRCM registers and >>> register bit fields should be modelled using hwmod. Since eQEP, ePWM and >> s/modelled/modeled/ > > Will fix. >> >>> eCAP don't fall under this category, remove their hwmod entries. >>> >>> Instead these clocks simply use the clock that is pass through by its >>> parent PWMSS. Therefore, PWMSS handles the clock for itself and its >>> subdevices. >> Are you breaking compatibility with old DTs here? > > No. The first patch makes sure that the ecap and ehrpwm get > their clocks from their parent which is all they care about. > Old dtbs will have hwmod entries for ecap and ehrpwm which > will end up not doing anything. Okay. Acked-by: Rob Herring