Date: Thu, 17 Mar 2016 21:20:51 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Jens Axboe <axboe@kernel.dk>
cc: Peter Zijlstra <peterz@infradead.org>,
        Xiong Zhou <jencce.kernel@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Andreas Herrmann <aherrmann@suse.com>
Subject: Re: 4.5.0+ panic when setup loop device
In-Reply-To: <56EAF6CC.7070108@kernel.dk>
Message-ID: <alpine.DEB.2.11.1603172113470.3978@nanos>
References: <CADJHv_ty-8OsX3YKKYg4vtzcL-Hmag3rtjObbcgFLE-KLt1M7g@mail.gmail.com> <alpine.DEB.2.11.1603161624280.3978@nanos> <CADJHv_s1cM=NxkCSHEm_1MctDYJUkDtutLB=aFtx9rB4a3FZdw@mail.gmail.com> <20160317095220.GO6344@twins.programming.kicks-ass.net>
 <alpine.DEB.2.11.1603171119060.3978@nanos> <20160317102633.GR6344@twins.programming.kicks-ass.net> <alpine.DEB.2.11.1603171223480.3978@nanos> <20160317115120.GT6344@twins.programming.kicks-ass.net> <alpine.DEB.2.11.1603171258260.3978@nanos> <56EADE5F.7000601@kernel.dk>
 <56EAF6CC.7070108@kernel.dk>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1688
Lines: 61

On Thu, 17 Mar 2016, Jens Axboe wrote:
> On 03/17/2016 09:42 AM, Jens Axboe wrote:
> > On 03/17/2016 05:01 AM, Thomas Gleixner wrote:
> > > On Thu, 17 Mar 2016, Peter Zijlstra wrote:
> > > > On Thu, Mar 17, 2016 at 12:39:46PM +0100, Thomas Gleixner wrote:
> > > > > But we have to clarify and document whether holes in
> > > > > cpu_possible_mask are not
> > > > > allowed at all or if code like the above is simply broken.
> > > > 
> > > > So the general rule is that cpumasks can have holes, and exempting one
> > > > just muddles the water.
> > > > 
> > > > Therefore I'd call the code just plain broken.
> > > 
> > > Agreed.
> > > 
> > > That macro is not really helping the readability of the code at all. So a
> > > simple for_each_possible_cpu() loop would have avoided that wreckage.
> > 
> > Does the attached work? The rest of blk-mq should deal with holes just

Bah. Attachements ...

> > fine, we found some of those issues on sparc. Not sure why this one
> > slipped through the cracks.
> 
> This might be better, we need to start at -1 to not miss the first one...
> Still untested.

> +static inline struct blk_mq_ctx *next_ctx(struct request_queue *q, int *i)
> +{
> +	do {
> +		(*i)++;
> +		if (*i < q->nr_queues) {
> +			if (cpu_possible(*i))
> +				return per_cpu_ptr(q->queue_ctx, *i);
> +			continue;
> +		}
> +		break;
> +	} while (1);
> +
> +	return NULL;
> +}
> +
> +#define queue_for_each_ctx(q, ctx, i)					\
> +	for ((i) = -1; (ctx = next_ctx((q), &(i))) != NULL;)
> +

What's wrong with

        for_each_possible_cpu(cpu) {
       		ctx = per_cpu_ptr(q->queue_ctx, cpu);

		....
	}

instead of hiding it behind an incomprehensible macro mess?

Thanks,

	tglx