Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S936863AbcCQVG0 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Mar 2016 17:06:26 -0400
Received: from vern.gendns.com ([50.115.127.205]:45753 "EHLO vern.gendns.com"
	rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP
	id S933058AbcCQVGX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Mar 2016 17:06:23 -0400
Subject: Re: [PATCH v2 11/11] usb: musb: da8xx: Remove mach code
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
References: <1458181615-27782-1-git-send-email-david@lechnology.com>
 <1458181615-27782-12-git-send-email-david@lechnology.com>
 <56EAAD09.3080600@cogentembedded.com>
Cc: Petr Kulhavy <petr@barix.com>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>, Sekhar Nori <nsekhar@ti.com>,
        Kevin Hilman <khilman@kernel.org>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Bin Liu <b-liu@ti.com>, Tony Lindgren <tony@atomide.com>,
        =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>,
        Robert Jarzmik <robert.jarzmik@free.fr>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-usb@vger.kernel.org
From: David Lechner <david@lechnology.com>
Message-ID: <56EAEB84.8060005@lechnology.com>
Date: Thu, 17 Mar 2016 12:38:12 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <56EAAD09.3080600@cogentembedded.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - vern.gendns.com
X-AntiAbuse: Original Domain - vger.kernel.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - lechnology.com
X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed
X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com
X-Source: 
X-Source-Args: 
X-Source-Dir: 
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 529
Lines: 16

On 03/17/2016 08:11 AM, Sergei Shtylyov wrote:
> On 3/17/2016 5:26 AM, David Lechner wrote:
>>
>>       glue->dev            = &pdev->dev;
>>       pdata->platform_ops        = &da8xx_ops;
>>
>> -    glue->phy = usb_phy_generic_register();
>> -    if (IS_ERR(glue->phy)) {
>> -        ret = PTR_ERR(glue->phy);
>> -        goto err5;
>> +    glue->usb_phy = usb_phy_generic_register();
>
>     Hm, do we still need the USB PHY? It does nothing IIRC...
>

Unfortunately, yes. It is used in musb_core, etc., mainly for otg->state.