Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S967316AbcCQVZx (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Mar 2016 17:25:53 -0400
Received: from mail-yw0-f173.google.com ([209.85.161.173]:35598 "EHLO
	mail-yw0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S967141AbcCQVZu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Mar 2016 17:25:50 -0400
MIME-Version: 1.0
In-Reply-To: <20160317211910.GB2611@joana>
References: <1458235817-28375-1-git-send-email-gustavo@padovan.org>
	<1458235817-28375-2-git-send-email-gustavo@padovan.org>
	<1458236486.9556.11.camel@perches.com>
	<20160317180523.GA2619@joana>
	<20160317184318.GA2611@joana>
	<1458246150.9556.17.camel@perches.com>
	<CAF6AEGvQa8SOWCtoEfcFAxz6MQ0Nqc-ktqNCdfJU-32-m-mCEQ@mail.gmail.com>
	<1458247207.9556.28.camel@perches.com>
	<CAF6AEGuzr2Vm_yngN7WcoeMLiiqb8B+kEBaNaPNqXdV2ZC-u-Q@mail.gmail.com>
	<1458249003.9556.30.camel@perches.com>
	<20160317211910.GB2611@joana>
Date: Thu, 17 Mar 2016 17:25:49 -0400
Message-ID: <CAF6AEGuaLLx1iEeDyfc3WNunp6md-OjBothY8Fw_FMo0eGoP3Q@mail.gmail.com>
Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr()
From: Rob Clark <robdclark@gmail.com>
To: Gustavo Padovan <gustavo@padovan.org>, Joe Perches <joe@perches.com>,
        Rob Clark <robdclark@gmail.com>,
        Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        devel@driverdev.osuosl.org,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        Daniel Stone <daniels@collabora.com>,
        =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>,
        Riley Andrews <riandrews@android.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Greg Hackmann <ghackmann@google.com>,
        John Harrison <John.C.Harrison@intel.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel.vetter@intel.com>,
        linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 940
Lines: 30

On Thu, Mar 17, 2016 at 5:19 PM, Gustavo Padovan <gustavo@padovan.org> wrote:
> 2016-03-17 Joe Perches <joe@perches.com>:
>
>> On Thu, 2016-03-17 at 16:50 -0400, Rob Clark wrote:
>> > On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches <joe@perches.com> wrote:
>> []
>> > > It's a name that seems like it should be a straightforward
>> > > cast of a kernel pointer to a __user pointer like:
>> > >
>> > > static inline void __user *to_user_ptr(void *p)
>> > > {
>> > >         return (void __user *)p;
>> > > }
>> > ahh, ok.  I guess I was used to using it in the context of ioctl
>> > structs..  in that context u64 -> (void __user *) made more sense.
>> >
>> > Maybe uapi_to_ptr()?  (ok, not super-creative.. maybe someone has a
>> > better idea)
>>
>> Maybe u64_to_user_ptr?
>
> That is a good name. If everyone agrees I can resend this patch
> changing it to u64_to_user_ptr. Then should we still keep it on
> kernel.h?


works for me

BR,
-R