Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031338AbcCQV0K (ORCPT ); Thu, 17 Mar 2016 17:26:10 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:34238 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967141AbcCQV0H (ORCPT ); Thu, 17 Mar 2016 17:26:07 -0400 Date: Thu, 17 Mar 2016 22:26:03 +0100 From: Pavel Machek To: pali.rohar@gmail.com, sre@kernel.org, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, maxime.ripard@free-electrons.com, ruslan.bilovol@gmail.com, m.szyprowski@samsung.com, peter.chen@freescale.com, balbi@ti.com Subject: usb: gadget breakage on N900: bind UDC by name passed via usb_gadget_driver structure Message-ID: <20160317212603.GA16651@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1222 Lines: 38 Hi! USB gadget stops working for me on n900, if I merge usb: gadget: bind UDC by name passed via usb_gadget_driver structure patch. commit 2284b29d3d9dd16490909962574d7f3fef83fd97 Author: Ruslan Bilovol Date: Mon Nov 23 09:56:35 2015 +0100 usb: gadget: bind UDC by name passed via usb_gadget_driver structure Introduce new 'udc_name' member to usb_gadget_driver structure. The 'udc_name' is a name of UDC that usb_gadget_driver should be bound to. If udc_name is NULL, it will be bound to any available UDC. Tested-by: Maxime Ripard Signed-off-by: Ruslan Bilovol Signed-off-by: Marek Szyprowski Tested-by: Peter Chen Signed-off-by: Felipe Balbi Patch is obvious enough... if there's someone who sets udc_name to NULL. Who is supposed to do that? (I have patch in my tree to make USB gadget work when it is not modular). Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html