Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756612AbcCQWQj (ORCPT ); Thu, 17 Mar 2016 18:16:39 -0400 Received: from mail-yw0-f196.google.com ([209.85.161.196]:36460 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752162AbcCQWQa convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2016 18:16:30 -0400 Date: Thu, 17 Mar 2016 19:16:19 -0300 From: Gustavo Padovan To: Joe Perches Cc: Rob Clark , Gustavo Padovan , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Greg Kroah-Hartman , Linux Kernel Mailing List , devel@driverdev.osuosl.org, "dri-devel@lists.freedesktop.org" , Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Greg Hackmann , John Harrison , Maarten Lankhorst , Andrew Morton , David Airlie , Daniel Vetter , linuxppc-dev Subject: Re: [PATCH v9 2/3] kernel.h: add to_user_ptr() Message-ID: <20160317221619.GA11578@joana> Mail-Followup-To: Gustavo Padovan , Joe Perches , Rob Clark , Gustavo Padovan , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Greg Kroah-Hartman , Linux Kernel Mailing List , devel@driverdev.osuosl.org, "dri-devel@lists.freedesktop.org" , Daniel Stone , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , Daniel Vetter , Greg Hackmann , John Harrison , Maarten Lankhorst , Andrew Morton , David Airlie , Daniel Vetter , linuxppc-dev References: <1458236486.9556.11.camel@perches.com> <20160317180523.GA2619@joana> <20160317184318.GA2611@joana> <1458246150.9556.17.camel@perches.com> <1458247207.9556.28.camel@perches.com> <1458249003.9556.30.camel@perches.com> <20160317211910.GB2611@joana> <1458250430.9556.39.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <1458250430.9556.39.camel@perches.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1552 Lines: 40 2016-03-17 Joe Perches : > On Thu, 2016-03-17 at 18:19 -0300, Gustavo Padovan wrote: > > 2016-03-17 Joe Perches : > > > On Thu, 2016-03-17 at 16:50 -0400, Rob Clark wrote: > > > > On Thu, Mar 17, 2016 at 4:40 PM, Joe Perches wrote: > > > [] > > > > > It's a name that seems like it should be a straightforward > > > > > cast of a kernel pointer to a __user pointer like: > > > > > > > > > > static inline void __user *to_user_ptr(void *p) > > > > > { > > > > >         return (void __user *)p; > > > > > } > > > > ahh, ok.  I guess I was used to using it in the context of ioctl > > > > structs..  in that context u64 -> (void __user *) made more sense. > > > > > > > > Maybe uapi_to_ptr()?  (ok, not super-creative.. maybe someone has a > > > > better idea) > > > Maybe u64_to_user_ptr? > > That is a good name. If everyone agrees I can resend this patch > > changing it to u64_to_user_ptr. Then should we still keep it on > > kernel.h? > > I've no particular opinion about location, > but maybe compat.h might be appropriate. I don't think this is really related to compat. I'd keep kernel.h. The problem I'm trying to solve here is: CC drivers/dma-buf/sync_file.o drivers/dma-buf/sync_file.c: In function ‘sync_file_ioctl_fence_info’: drivers/dma-buf/sync_file.c:341:19: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] if (copy_to_user((void __user *)info.sync_fence_info, fence_info, where info.sync_fence_info is __u64. Gustavo