Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756710AbcCQWiR (ORCPT ); Thu, 17 Mar 2016 18:38:17 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:36794 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753157AbcCQWiL (ORCPT ); Thu, 17 Mar 2016 18:38:11 -0400 Subject: Re: [PATCH v5 1/6] pwms: pwm-ti*: Get the clock from the PWMSS (parent) To: , , , , , , , , , , , , , , , References: <1457400224-24797-1-git-send-email-fcooper@ti.com> <1457400224-24797-2-git-send-email-fcooper@ti.com> From: "Franklin S Cooper Jr." Message-ID: <56EB319E.3050502@ti.com> Date: Thu, 17 Mar 2016 17:37:18 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1457400224-24797-2-git-send-email-fcooper@ti.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1419 Lines: 39 Gentle ping on this On 03/07/2016 07:23 PM, Franklin S Cooper Jr wrote: > The eCAP and ePWM doesn't have their own separate clocks. They simply > utilize the clock provided directly by the PWMSS. Therefore, they simply > need to grab a reference to their parent's clock. > > Signed-off-by: Franklin S Cooper Jr > --- > drivers/pwm/pwm-tiecap.c | 2 +- > drivers/pwm/pwm-tiehrpwm.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c > index 616af76..9418159 100644 > --- a/drivers/pwm/pwm-tiecap.c > +++ b/drivers/pwm/pwm-tiecap.c > @@ -212,7 +212,7 @@ static int ecap_pwm_probe(struct platform_device *pdev) > if (!pc) > return -ENOMEM; > > - clk = devm_clk_get(&pdev->dev, "fck"); > + clk = devm_clk_get(pdev->dev.parent, "fck"); > if (IS_ERR(clk)) { > dev_err(&pdev->dev, "failed to get clock\n"); > return PTR_ERR(clk); > diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c > index 6a41e66..09dc1bc 100644 > --- a/drivers/pwm/pwm-tiehrpwm.c > +++ b/drivers/pwm/pwm-tiehrpwm.c > @@ -443,7 +443,7 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev) > if (!pc) > return -ENOMEM; > > - clk = devm_clk_get(&pdev->dev, "fck"); > + clk = devm_clk_get(pdev->dev.parent, "fck"); > if (IS_ERR(clk)) { > dev_err(&pdev->dev, "failed to get clock\n"); > return PTR_ERR(clk);