Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967423AbcCRA3r (ORCPT ); Thu, 17 Mar 2016 20:29:47 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:59529 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbcCRA3h (ORCPT ); Thu, 17 Mar 2016 20:29:37 -0400 Message-ID: <1458260968.3431.0.camel@decadent.org.uk> Subject: Re: [PATCH v1 1/2] ethtool: minor doc update From: Ben Hutchings To: David Decotigny , "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Nikolay Aleksandrov , "Michael S. Tsirkin" , Jeff Kirsher , David Decotigny , Nicolas Dichtel , Andrew Lunn , Hadar Hen Zion , Edward Cree , John Fastabend , Herbert Xu , Thomas Graf , Daniel Borkmann , Ken-ichirou MATSUZAWA , Florian Westphal , David Herrmann Date: Fri, 18 Mar 2016 00:29:28 +0000 In-Reply-To: <1458259436-85275-2-git-send-email-ddecotig@gmail.com> References: <1458259436-85275-1-git-send-email-ddecotig@gmail.com> <1458259436-85275-2-git-send-email-ddecotig@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-V+AoYTaMdMZKcAZu9y/r" X-Mailer: Evolution 3.18.5.1-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2752 Lines: 64 --=-V+AoYTaMdMZKcAZu9y/r Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2016-03-17 at 17:03 -0700, David Decotigny wrote: > From: David Decotigny >=20 > Updates: commit 793cf87de9d1 ("ethtool: Set cmd field in > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ETHTOOL_GLINKSETTIN= GS response to wrong nwords") >=20 > Signed-off-by: David Decotigny Reviewed-by: Ben Hutchings > --- > =C2=A0include/uapi/linux/ethtool.h | 6 +++--- > =C2=A01 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h > index 2835b07..9222db8 100644 > --- a/include/uapi/linux/ethtool.h > +++ b/include/uapi/linux/ethtool.h > @@ -1648,9 +1648,9 @@ enum ethtool_reset_flags { > =C2=A0 * %ETHTOOL_GLINKSETTINGS: on entry, number of words passed by user > =C2=A0 * (>=3D 0); on return, if handshake in progress, negative if > =C2=A0 * request size unsupported by kernel: absolute value indicates > - * kernel recommended size and cmd field is 0, as well as all the > - * other fields; otherwise (handshake completed), strictly > - * positive to indicate size used by kernel and cmd field is > + * kernel expected size and all the other fields but cmd > + * are 0; otherwise (handshake completed), strictly positive > + * to indicate size used by kernel and cmd field stays > =C2=A0 * %ETHTOOL_GLINKSETTINGS, all other fields populated by driver. Fo= r > =C2=A0 * %ETHTOOL_SLINKSETTINGS: must be valid on entry, ie. a positive > =C2=A0 * value returned previously by %ETHTOOL_GLINKSETTINGS, otherwise --=20 Ben Hutchings Absolutum obsoletum. (If it works, it's out of date.) - Stafford Beer --=-V+AoYTaMdMZKcAZu9y/r Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJW60voAAoJEOe/yOyVhhEJF5QP/2iTwg8ck6eIe4CaADd9jlwe FOvh194fBi4etaZmKnT/gaecSrM0iwvavO/9rKepbs1LqtLfazt6meRaRmdJLdfo FN2aSm0usdzRbobjcFvn34SXRQ3ARXjnTRaOQI2bSoP9sGkak8HR8/ttR8W3rGgr hWSrPHUVvMSrIQmq1z3gvaV2p1sI796ABDh7UVcFMhLo85ZCooT3LXc28+t/Ibxr dCbw0I4X2EkAUHCq2R2q0So312drm3FesM+Rr9TCSG/FkOxZtzJd48XDkR5ciEvf Vbos/+2tVe4+20h+kGymdFu+77glH2M19Qg52p3JYbAtuIh/7DPrt7bH29V73Av4 dygLSpcfhHNk5fpGjgQ2vKh2sO/ecVPXPryf39UE3BPfbceNHp9tP8Z7pKIR6wB7 bJgt1+2o0AzHPIw1scyHwBYUIH1qJmKjqJ+/tcW2YeeNQs9zG/xpP0puYMbOrayd 2y0KT3Y9mA1wssdecAvoTVUCbUBD9iGiDm+d5JaWonGSGaQPCiWAmjodMFm+4Fv0 DZXIQheLUIRLkYgZ1aW1nSRx8fUVTT28+EoOCA2/K/bSIkx9W7/l4urOcVDQ9YXm CtFLDa2U5c9DXQNwgWNat58CvvFtJ9X9fGK9WM5ggFjXNXEsanh4VbW/EDWXrcpa awM1DzkyiRwAEr/R+Zrr =Mkr5 -----END PGP SIGNATURE----- --=-V+AoYTaMdMZKcAZu9y/r--