Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935648AbcCRAhC (ORCPT ); Thu, 17 Mar 2016 20:37:02 -0400 Received: from e17.ny.us.ibm.com ([129.33.205.207]:53152 "EHLO e17.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933912AbcCRAgx (ORCPT ); Thu, 17 Mar 2016 20:36:53 -0400 X-IBM-Helo: d01dlp02.pok.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Thu, 17 Mar 2016 17:28:15 -0700 From: "Paul E. McKenney" To: Peter Zijlstra Cc: Chris Metcalf , Russell King , Thomas Gleixner , Aaron Tomlin , Ingo Molnar , Andrew Morton , Daniel Thompson , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods Message-ID: <20160318002815.GB4287@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1458147733-29338-1-git-send-email-cmetcalf@mellanox.com> <1458147733-29338-2-git-send-email-cmetcalf@mellanox.com> <20160317193600.GY6344@twins.programming.kicks-ass.net> <20160317225557.GA4287@linux.vnet.ibm.com> <20160317231128.GB6344@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160317231128.GB6344@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031800-0041-0000-0000-000003A0BDF8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 672 Lines: 17 On Fri, Mar 18, 2016 at 12:11:28AM +0100, Peter Zijlstra wrote: > On Thu, Mar 17, 2016 at 03:55:57PM -0700, Paul E. McKenney wrote: > > The RCU stall-warn stack traces can be ugly, agreed. > > Ugly isn't the problem, completely random bollocks that puts you on the > wrong path was more the problem. > > It uses a stack pointer saved at some random time in the past to start > unwinding an active stack from. Completely and utter misery. Yep, its accuracy does depend on what is going on, which was also my experience with the NMI-based approach's reliablity. Perhaps a boot-time parameter enabling the sysadm to pick the desired flavor of poison? Thanx, Paul