Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752629AbcCRDWw (ORCPT ); Thu, 17 Mar 2016 23:22:52 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:33328 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752545AbcCRDWg (ORCPT ); Thu, 17 Mar 2016 23:22:36 -0400 Subject: Re: [PATCH] nios2: Replace fdt_translate_address with of_flat_dt_translate_address To: Guenter Roeck , Ley Foon Tan References: <1458269396-971-1-git-send-email-linux@roeck-us.net> Cc: nios2-dev@lists.rocketboards.org, linux-kernel@vger.kernel.org, Rob Herring From: Peter Hurley Message-ID: <56EB7478.9080401@hurleysoftware.com> Date: Thu, 17 Mar 2016 20:22:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1458269396-971-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1490 Lines: 43 Hi Guenter, On 03/17/2016 07:49 PM, Guenter Roeck wrote: > nios2 builds fail with the following build error. > > arch/nios2/kernel/prom.c: In function 'early_init_dt_scan_serial': > arch/nios2/kernel/prom.c:100:2: error: > implicit declaration of function 'fdt_translate_address' > > Commit c90fe9c0394b ("of: earlycon: Move address translation to > of_setup_earlycon()") replaced fdt_translate_address() with > of_flat_dt_translate_address() but missed updating the nios2 code. My bad. The sad part is I even noted this other user of fdt_translate_address() in a review of a different patch, and then overlooked it in my own patch. :/ Reviewed-by: Peter Hurley > Fixes: c90fe9c0394b ("of: earlycon: Move address translation to of_setup_earlycon()") > Cc: Peter Hurley > Cc: Rob Herring > Signed-off-by: Guenter Roeck > --- > arch/nios2/kernel/prom.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/nios2/kernel/prom.c b/arch/nios2/kernel/prom.c > index 718dd197909f..367c5426157b 100644 > --- a/arch/nios2/kernel/prom.c > +++ b/arch/nios2/kernel/prom.c > @@ -97,8 +97,7 @@ static int __init early_init_dt_scan_serial(unsigned long node, > return 0; > #endif > > - *addr64 = fdt_translate_address((const void *)initial_boot_params, > - node); > + *addr64 = of_flat_dt_translate_address(node); > > return *addr64 == OF_BAD_ADDR ? 0 : 1; > } >