Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752961AbcCRFMy (ORCPT ); Fri, 18 Mar 2016 01:12:54 -0400 Received: from mga11.intel.com ([192.55.52.93]:63868 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752900AbcCRFMx (ORCPT ); Fri, 18 Mar 2016 01:12:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,353,1455004800"; d="scan'208";a="939917112" Subject: Re: [alsa-devel] [PATCH] ASoC: dapm: Do not traverse widget hooks to snd-soc-dummy To: Mark Brown , Lars-Peter Clausen References: <1458127071-14417-1-git-send-email-harry.pan@intel.com> <20160317095438.GD2566@sirena.org.uk> <1458211115.965.13.camel@intel.com> <20160317112514.GE2566@sirena.org.uk> <56EAA4FC.5090408@metafoo.de> <20160317154236.GH2566@sirena.org.uk> Cc: "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "tiwai@suse.com" , "lgirdwood@gmail.com" , "Pan, Harry" , "gs0622@gmail.com" From: Vinod Koul Message-ID: <56EB8F58.6040609@linux.intel.com> Date: Fri, 18 Mar 2016 10:47:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160317154236.GH2566@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 862 Lines: 20 On Thursday 17 March 2016 09:12 PM, Mark Brown wrote: > On Thu, Mar 17, 2016 at 01:37:16PM +0100, Lars-Peter Clausen wrote: > >> I'd say as a quick fix for stable check that card is not NULL in >> dapm_widget_show_component(). And as a longterm fix get rid of dapm_widget >> file. Nobody should hopefully use it anymore with debugfs being available as >> the far better alternative. > > Getting rid of the file is definitely not a bad idea but I'd still like > to see us make the dummy component more consistent with other components > in order to minimise the chances that we'll run into other special > cases. Right, I do see that we need dummy component to be fixed up. Today if we use dummy twice in a card it refers to same instance whereas IMO it should create separate instances. I will try something on these lines in next month or so... -- ~Vinod