Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757218AbcCRGOE (ORCPT ); Fri, 18 Mar 2016 02:14:04 -0400 Received: from mail-bn1bon0076.outbound.protection.outlook.com ([157.56.111.76]:54816 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757138AbcCRGNL convert rfc822-to-8bit (ORCPT ); Fri, 18 Mar 2016 02:13:11 -0400 X-Greylist: delayed 894 seconds by postgrey-1.27 at vger.kernel.org; Fri, 18 Mar 2016 02:13:10 EDT Authentication-Results: spf=softfail (sender IP is 66.35.236.227) smtp.mailfrom=altera.com; roeck-us.net; dkim=none (message not signed) header.d=none;roeck-us.net; dmarc=none action=none header.from=altera.com; Message-ID: <1458280683.2963.11.camel@ubuntu> Subject: Re: [PATCH] nios2: Replace fdt_translate_address with of_flat_dt_translate_address From: Ley Foon Tan To: Peter Hurley CC: Guenter Roeck , , , Rob Herring Date: Fri, 18 Mar 2016 13:58:03 +0800 In-Reply-To: <56EB7478.9080401@hurleysoftware.com> References: <1458269396-971-1-git-send-email-linux@roeck-us.net> <56EB7478.9080401@hurleysoftware.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:66.35.236.227;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(189002)(377454003)(377424004)(24454002)(199003)(479174004)(19580395003)(19580405001)(92566002)(106466001)(47776003)(81166005)(33646002)(103116003)(86362001)(110136002)(87936001)(189998001)(2950100001)(42186005)(23676002)(33716001)(50466002)(105596002)(5008740100001)(76176999)(50226001)(6806005)(1220700001)(4326007)(50986999)(5820100001)(586003)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR0301MB2031;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:SoftFail;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD040;1:0yYkkdcF1o56pKrq8xEAta79zug4qVFl2YgnMyc9p9A1PnLjPMfRu7uf49wdfKf26p+hq+Qul/TAon0fdLPsL3jrwY0UJ+SAM+ncg5ODnXD+m5pfsVrlIeURtYsfTO7d6RxP3xIx3oO4cUNv8nq961Yaiix6cdn0YgrJ/Jn76t+wvS6esDJhTxNZgCWRSQ0Uj/A+S9FkZ3QFlouxejEkGcqWFulX2qaFkOVeCpmOmS+qECd2fVJtTuTxC6zwZpBT0odyE+PbPk3FhUQXU+ulYi6T6pQsL/GH+gbpn9v4RfQXpEdRVqqHXcKQUhzlE4Z3spBAIdXx/huuW50eQqQMwLIALQPCaVLFxi93+GKLHEVyk4SgqAL++YT5u55jJvFXzE4pumICr8jaO50BE6U6YrljQvPw/uKFTF4siFCp1eIkX3bz7O1B2yeSWTh0eMsUcqUUlDHuoLVzf1azTEe8zlX6Gi97d/cd4a4Xx+8P1+g= X-MS-Office365-Filtering-Correlation-Id: 3f1abbf3-39b7-47d8-d6fb-08d34ef24a2f X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB2031;2:EM2q0LvVAzZY/r0wKfEcsoJbeIwe1MQfWCxUcj4FG12fFM/2TsUM5P5iYIQUTPm5DzYRH5z8d4XhDl90eOEdo9xgrz74x3dDBJtAI+RMVW/Ijqy4SId9qBDRqSo6SgkqIP3ergpXUgAHBvhgF2PUxXPLrXK+6n8mELWpmz5Ti+hicutY0yosOdDaYPVyv2iP;3:6Tr8cJp5YXUa3sx4sXWcsQWuzAFd29+uhrBZo8Sc+9pnKv8OHvbml4A/N6pZuNQ+oYUeb/DawGINij1OoMQjifLuwVrDADl3GLolNBWMqrd8Y5sUiZte3QC3S4UuMM2BBgGEq4wJFapKl1jqYCe0JO8Xq32EVA+wQGODd6toqpYnj5QEi7QP8ZsDtYf5tk6BXElmAQ/Bcd4iBzRDwt1IMy/arrYkTCbp1QEM561vejU= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB2031; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB2031;25:19dv/e+XftQOFxHcKi4ceb/EHrs/P824BrmOuWG/8rgUQgXfvCbFnmLUor+/mWvB9NwmrTW2sKGbD7eDBhNr3ePQbwBHkvBBp/q7r63tD8yrnRxPYAmdcYx5EN98NTgY3Lt9eFX6ABnnDEr1lqkkvMfi1RgNubtj09SRUuj/34dE1fvbDRaF34IhH1ChDGJHc50+OdeSJBFwFDzd17qjpQUX6xlkNXYCLiEy+MD/M6JvtRCcPJbMYC/ncbIh1fmVuGIosJyIgVDIIQDYaFmuK2Q2tVpR+4Fp8KewPB7eEwNOgpt/S3QApdGMeS4y2zIH2zn1A7FgkfvKZybQORJBabcRMFgBmH6E4eSLmaWusVROFQuqdy+9mNyBhiMEwDM2z8wTa6xZXYJKCmhV/l3iWv+CqTEIJ4o9rMykTym1NxDFbYdsDdWu5c3V0UEW69FyoNKMKlqxDo/+dapcUfKrVG10z88DCWBYpS6KtP1hF0FS6vNbi8uicx9PnEckEe7k8NOIyBPNGalpo/jZ3GUiwb8xXhqKk2zqjf2b/PC44YnZZC266C7gCYVqF/N0gzRQ;20:SA+4EAsR0ekXEoAKuKf1prLLYp15ufb/4cWDntTc9EHwvlNyxBFd0b3ynNW88a7M1uURacWvMg4OlOXtY2HsJG9LGHQ70bDPoADz5FE7gWws5a704oMR4MJz0t7BAZr0lrtvBDH99m1xHTVmJRb4PnrlO28D9aF3QOQ+RQMQ3DY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13024025)(8121501046)(13015025)(5005006)(13023025)(13017025)(13018025)(10201501046)(3002001);SRVR:SN1PR0301MB2031;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB2031; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB2031;4:vS1EiGKh8cxtSxgCba22cYg+cVzwguIxjzrpbSAdih/6RYqDwyDeQyQDpE7TS4BaaVCrWsPe4+SiX2i6l/4GO2ONsXeHzEkgp3n5cyFPbkZuA8KlyfHlnvbIiyZqKSlRo8jQV0HREiLeoUs4I2uaFxc27rjcokQMuws6i/3e86mGUXn+Ygo3di56RprbBaoYdHuQ7vx2BAsSxRVvm9lXp2EUW4J99aW2SIVCIgZBMkrHTEcvUSDggvBqxNvq6VzWXGRJ+ornAAzDxdTDvkNx/0CNdqLpCuwKwacS6rUoVV8+wrFis7WMiiO2Gh1K/82i2mKf0LtXfPXIVPG/u0EUdfgI8QZ4tZ4hJLMInnMGYaBhGCBIgkqci//cuEW3aCF0CNpvHOU1ijS8DMt3aRPsqlau2bgbeAxMXkejNoEyH43fBtXnmR5FTMeITt808Dxra2bZ4jnGogv0OBMTkBYZfg== X-Forefront-PRVS: 088552DE73 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjAzMDFNQjIwMzE7MjM6RHE0VlpPRmFKLzhDQk50UENvd3RDdkdk?= =?utf-8?B?MDVVc3Z5dzE4TzZ2Um5GQlBwTU42dFhrZzZlT0c4S2JtbEtaclEvakdTYUkw?= =?utf-8?B?bmpiK3EwLzFQaWJTUUJzQ1doWFpmRm1EODBvb05uQ1ZaWDg3NlFwTTN1RVZY?= =?utf-8?B?dzVDRm5yWjJNL1NXNEtQZThJQ1JMK0dWM0VQMXM3Y3l2UThGellpME5pdUZ1?= =?utf-8?B?bTI1em9iM0JIUEFJanUvVmIvOU9PcTVEcTF0a1ZrMkp3dDJvL0o0SXNrT0xS?= =?utf-8?B?Q21PckM3akJHTmFWbXMrUUllSjlaS3FtUjZKN1gzd2YzbXQzWldCY0xwNWNt?= =?utf-8?B?aEh3T21FbUlwamV5OEg2ZXNhWWZValU5Zlo4ZkY2ME9NNlU1MWFPWWtqWnh3?= =?utf-8?B?NEZQazhIUUJ5a0NIbGFGN3BaS1VmWGJNTk1JREMxTlZGbUVSM0xQbElDaTJo?= =?utf-8?B?YVE5Q2ptOERVcmxtTnNsWkJGMmQySDZJSHB2TVV0SjB3LzgvSUptdDlTRHk2?= =?utf-8?B?SmdKMnVISGRVcGdBRnV2N0hpWmtmV1ZOLzNwL3BtdFppT24wV2kyUEpzQUwy?= =?utf-8?B?Vk53WUhVaWlFNzQ0UzBTRVVIZmZOeXgwRXhuTENkNnNjTWpyZExKQk1JQ0RB?= =?utf-8?B?RWh2Z2czNGUrdnlYbzJUWHRLaFFhdDFuZkdWdDM5K0tsN0swakFRWjhNT3dv?= =?utf-8?B?alV6Y1VBMDExVkltaS9xYzB1dlV0SG5CU1RLYUJ1akIwYlNDMnpXWHI0MmxU?= =?utf-8?B?RzlDN3g1OG9aRFpTcTliWXNxRDBrSm5nY3AvVzhXWWVJVzAwMytaMmVkWXhR?= =?utf-8?B?bFFYZjlQb0V2bFNIcjZzdnhpRmpoNE04aXBxbyt0Z3YzNW9jUU55MnhRY2RZ?= =?utf-8?B?SWFmOTVjcVdZMmF0YUVqeFdNYjZOTHgxUTZEbEE1WFlMd3p2T0pRdWh0UUtv?= =?utf-8?B?ZENOSGZoL1ZPSDY0SlpaR3VZYnQzSGpINFNqdmNmSzlaZE12dHBXRVZoOHFC?= =?utf-8?B?STE3RldIbTVNclhTZ3ZFUFFERU1YM1dtY0gwc2tHOHd4RGVvTm9hRkpiWFA5?= =?utf-8?B?SE12a0Fkb1lSYlZGYjFWQTk0aVpIaU9IVzE2emxtYUZPOVZTT3FUZ20wUHVO?= =?utf-8?B?VTdJU0hNVWY3RXNJbHNDRU5paWx4K0xlTVJyM1N3akNCZGZ6VzIvWXowUGg4?= =?utf-8?B?bHhCZTVKcmQxYy9HNkk5dnRKTjlmb2NIS2FveVUwSzB0WGRsdm9wZTRSNDNu?= =?utf-8?B?b09ESXZrREt0T0RnMFdMb0lTQnM2UEpFYzJGcC9xTXlWUDhLSGFkV0o1VFBY?= =?utf-8?B?WUx5c3d3RWV2WVJNUT09?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0301MB2031;5:ghT3nqfeNvirUS8LXyCTeiPOfYV4R9+sYlR1vz509r7jK8xQSyvrWfOBqB+215Z9424dJcgoZxIOdlJOZbXS9XmlO2qMxDTokZuXUd8kokikyfooMDnZ7AURSUoabwTuYwUq3pH/AK4tEiticbE/3g==;24:qVyRnjJKmIDH6wRnAqMTkaZ6w5P4FimwUtjDomOszMd0zzWNl4JeRo0WGtlvbiB9fNGu21WHUJglv7hyjtQ71TQqVWcanRF+UJLmT4UpbVM=;20:2FZS9LgcIeHI8RXqrf9r+RgxWBhzRq83V4SIMhYrKMLbvMnYsyNgFP3HiECuhj2S9pPZfVa4UnaRWoSzDnwLnniYok0zFQnHpj8MErsQCsCN4oqPYafFc6n3mPC00pp3pLBwH1yGgNG46GCJZpY1dRNBc3JmKhwgfrNAsXvAlTI= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2016 05:58:11.9485 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB2031 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 880 Lines: 27 On Thu, 2016-03-17 at 20:22 -0700, Peter Hurley wrote: > Hi Guenter, > > On 03/17/2016 07:49 PM, Guenter Roeck wrote: > > nios2 builds fail with the following build error. > > > > arch/nios2/kernel/prom.c: In function 'early_init_dt_scan_serial': > > arch/nios2/kernel/prom.c:100:2: error: > > implicit declaration of function 'fdt_translate_address' > > > > Commit c90fe9c0394b ("of: earlycon: Move address translation to > > of_setup_earlycon()") replaced fdt_translate_address() with > > of_flat_dt_translate_address() but missed updating the nios2 code. > > My bad. > The sad part is I even noted this other user of fdt_translate_address() > in a review of a different patch, and then overlooked it in my own patch. :/ > > Reviewed-by: Peter Hurley > Hi Peter, Will you take this patch or you want me to take this? Thanks. Regards Ley Foon