Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753519AbcCRIcx (ORCPT ); Fri, 18 Mar 2016 04:32:53 -0400 Received: from casper.infradead.org ([85.118.1.10]:55464 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752400AbcCRIco (ORCPT ); Fri, 18 Mar 2016 04:32:44 -0400 Date: Fri, 18 Mar 2016 09:32:36 +0100 From: Peter Zijlstra To: kan.liang@intel.com Cc: tglx@linutronix.de, ak@linux.intel.com, eranian@google.com, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] x86/perf/intel/uncore: Make Intel uncore modular Message-ID: <20160318083236.GE6344@twins.programming.kicks-ass.net> References: <1458218055-25920-1-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458218055-25920-1-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 409 Lines: 16 On Thu, Mar 17, 2016 at 05:34:14AM -0700, kan.liang@intel.com wrote: > +static void __exit intel_uncore_exit(void) > +{ > + cpu_notifier_register_done(); Did you even test this? That should be _begin(); > + __unregister_cpu_notifier(&uncore_cpu_nb); > + uncore_types_exit(uncore_msr_uncores); > + uncore_pci_exit(); > + cpu_notifier_register_done(); > +} > +module_exit(intel_uncore_exit); > -- > 2.5.0 >