Date: Fri, 18 Mar 2016 09:45:30 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
cc: kan.liang@intel.com, ak@linux.intel.com, eranian@google.com,
        mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86/perf/intel/uncore: Make Intel uncore modular
In-Reply-To: <20160318083236.GE6344@twins.programming.kicks-ass.net>
Message-ID: <alpine.DEB.2.11.1603180944320.3978@nanos>
References: <1458218055-25920-1-git-send-email-kan.liang@intel.com> <20160318083236.GE6344@twins.programming.kicks-ass.net>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 441
Lines: 13

On Fri, 18 Mar 2016, Peter Zijlstra wrote:

> On Thu, Mar 17, 2016 at 05:34:14AM -0700, kan.liang@intel.com wrote:
> > +static void __exit intel_uncore_exit(void)
> > +{
> > +	cpu_notifier_register_done();
> 
> Did you even test this? That should be _begin();

That's my fault. I had this in my proof of concept patch and it actually works
for some reason. By some definition of works: i.e. it does not explode in your
face right away....