Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756974AbcCRKd7 (ORCPT ); Fri, 18 Mar 2016 06:33:59 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:60921 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755730AbcCRKdv (ORCPT ); Fri, 18 Mar 2016 06:33:51 -0400 Subject: Re: Nokia N900 - audio TPA6130A2 problems To: Ivaylo Dimitrov , Grygorii Strashko , Sebastian Reichel , =?UTF-8?Q?Pali_Roh=c3=a1r?= References: <201507251228.27128@pali> <201601050034.12810@pali> <20160306152339.GA428@earth> <201603121342.33099@pali> <56E68B71.2030202@ti.com> <20160316133319.GR8413@pali> <20160316144709.GA3389@earth> <56E9A42B.3010209@gmail.com> <56E9A6D9.7000003@ti.com> <56E9B910.7000904@gmail.com> <56EA6282.5050501@ti.com> <56EAE8C3.1080301@gmail.com> CC: Jarkko Nikula , Tony Lindgren , Lars-Peter Clausen , , , Pavel Machek , Aaro Koskinen , Nishanth Menon , From: Peter Ujfalusi Message-ID: <56EBD96A.8090505@ti.com> Date: Fri, 18 Mar 2016 12:33:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <56EAE8C3.1080301@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 846 Lines: 29 On 03/17/16 19:26, Ivaylo Dimitrov wrote: > Hi, > >> >> can you try this: >> diff --git a/sound/soc/codecs/tpa6130a2.c b/sound/soc/codecs/tpa6130a2.c >> index 11d85c5c787a..7f5881bff5d9 100644 >> --- a/sound/soc/codecs/tpa6130a2.c >> +++ b/sound/soc/codecs/tpa6130a2.c >> @@ -386,6 +386,8 @@ static int tpa6130a2_probe(struct i2c_client *client, >> data->power_gpio = pdata->power_gpio; >> } else if (np) { >> data->power_gpio = of_get_named_gpio(np, "power-gpio", 0); >> + if (data->power_gpio == -EPROBE_DEFER) >> + return data->power_gpio; >> } else { >> dev_err(dev, "Platform data not set\n"); >> dump_stack(); >> > > > Doesn't help :( it worth a try ;) But enabling the pull via DT for the i2c2 works? -- P?ter