Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757288AbcCRK5K (ORCPT ); Fri, 18 Mar 2016 06:57:10 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:1810 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753822AbcCRK5F (ORCPT ); Fri, 18 Mar 2016 06:57:05 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Fri, 18 Mar 2016 03:56:12 -0700 Subject: Re: [PATCH 14/15] dt-bindings: arm-gic: Drop 'clock-names' from binding document To: Geert Uytterhoeven References: <1458224359-32665-1-git-send-email-jonathanh@nvidia.com> <1458224359-32665-15-git-send-email-jonathanh@nvidia.com> <56EBD4E5.1060002@nvidia.com> CC: Thomas Gleixner , Jason Cooper , Marc Zyngier , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Tony Lindgren , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Stephen Warren , Thierry Reding , Kevin Hilman , Grygorii Strashko , Lars-Peter Clausen , Linus Walleij , , "linux-omap@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Jon Hunter Message-ID: <56EBDEFA.30102@nvidia.com> Date: Fri, 18 Mar 2016 10:56:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.21.132.114] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1459 Lines: 31 On 18/03/16 10:52, Geert Uytterhoeven wrote: > Hi Jon, > > On Fri, Mar 18, 2016 at 11:13 AM, Jon Hunter wrote: >> On 18/03/16 09:13, Geert Uytterhoeven wrote: >>> On Thu, Mar 17, 2016 at 3:19 PM, Jon Hunter wrote: >>>> Commit afbbd2338176 ("irqchip/gic: Document optional Clock and Power >>>> Domain properties") documented optional clock and power-dmoain properties >>>> for the ARM GIC. Currently, there are no users of these and for the >>>> Tegra210 Audio GIC (based upon the GIC-400) there are two clocks, a >>>> functional clock and interface clock, that need to be enabled. >>> >>> The reason that there are no users for this is twofold: >>> 1. The GIC driver doesn't have Runtime PM support yet, >>> 2. There was no clean way to prevent the GIC's clock from being disabled. >>> Due to this, adding the clocks to the DTSes would mean that they will be >>> disabled during boot up as unused clocks, leading to a system lock-up. >>> >>> I had hoped your series would fix part 1. I gave it a try on r8a7791/koelsch, >>> but unfortunately it seems the platform driver only supports non-root >>> controllers, while the r8a7791 GIC is the primary one... >> >> Can you try making the following change ... > > Thanks! I gave it a try, but no difference. I assume you added the appropriate compatible flag? Any more details you can share about why it is not working? Is it not registered early enough? Jon