Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754962AbcCRK6z (ORCPT ); Fri, 18 Mar 2016 06:58:55 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:43337 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751833AbcCRK6s (ORCPT ); Fri, 18 Mar 2016 06:58:48 -0400 Date: Fri, 18 Mar 2016 10:58:33 +0000 From: Russell King - ARM Linux To: Alexandre Courbot Cc: Marek Szyprowski , Rabin Vincent , Thierry Reding , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gnurou@gmail.com Subject: Re: [PATCH v2] ARM: DMA: Fix kzalloc flags in __dma_alloc Message-ID: <20160318105833.GF19428@n2100.arm.linux.org.uk> References: <1458293329-5519-1-git-send-email-acourbot@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458293329-5519-1-git-send-email-acourbot@nvidia.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 861 Lines: 23 On Fri, Mar 18, 2016 at 06:28:49PM +0900, Alexandre Courbot wrote: > Commit 19e6e5e5392b ("ARM: 8547/1: dma-mapping: store buffer > information") allocates a structure meant for internal buffer management > with the GFP flags of the buffer itself. This can trigger the following > safeguard in the slab/slub allocator: > > if (unlikely(flags & GFP_SLAB_BUG_MASK)) { > pr_emerg("gfp: %u\n", flags & GFP_SLAB_BUG_MASK); > BUG(); > } > > Fix this by filtering the flags that make the slab allocator unhappy. > > Signed-off-by: Alexandre Courbot > Cc: Rabin Vincent Looks much better than the original. Please send it to the patch system, thanks. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.