Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932266AbcCRLLL (ORCPT ); Fri, 18 Mar 2016 07:11:11 -0400 Received: from 8bytes.org ([81.169.241.247]:55055 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757372AbcCRLLD (ORCPT ); Fri, 18 Mar 2016 07:11:03 -0400 Date: Fri, 18 Mar 2016 12:11:01 +0100 From: Joerg Roedel To: Borislav Petkov Cc: Suravee Suthikulpanit , Peter Zijlstra , mingo@redhat.com, acme@kernel.org, andihartmann@freenet.de, vw@iommu.org, labbott@redhat.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Message-ID: <20160318111100.GG2195@8bytes.org> References: <20160314163913.GO6344@twins.programming.kicks-ass.net> <56E759C3.5040707@amd.com> <20160315104017.GA4559@pd.tnic> <20160315105318.GU6344@twins.programming.kicks-ass.net> <56EBA92D.7010906@amd.com> <20160318090441.GA7817@pd.tnic> <56EBC5CD.7070701@amd.com> <20160318092910.GC7817@pd.tnic> <56EBD31F.6050206@amd.com> <20160318103918.GD7817@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160318103918.GD7817@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 550 Lines: 16 On Fri, Mar 18, 2016 at 11:39:18AM +0100, Borislav Petkov wrote: > Yeah, so arch/x86/include/asm/ has all the x86-specific stuff which is > not exported to userspace, so moving stuff there makes sense to me. While the AMD IOMMU is only available on x86 today, there is nothing x86-specific in its architecture, so I don't think its header files belong to arch/x86. By that reasoning we could also move all of the intel gpu stuff to arch/x86. But we don't do it, because it doesn't make sense and because it doesn't belong there. Regards, Joerg