Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932901AbcCRNOf (ORCPT <rfc822;w@1wt.eu>);
	Fri, 18 Mar 2016 09:14:35 -0400
Received: from mail.kernel.org ([198.145.29.136]:50019 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752333AbcCRNOc convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 18 Mar 2016 09:14:32 -0400
MIME-Version: 1.0
In-Reply-To: <56EBBFB1.6000808@rock-chips.com>
References: <1457439716-8084-1-git-send-email-andy.yan@rock-chips.com>
 <1457439785-8133-1-git-send-email-andy.yan@rock-chips.com>
 <20160317155212.GA19171@rob-hp-laptop> <56EBBFB1.6000808@rock-chips.com>
From: Rob Herring <robh@kernel.org>
Date: Fri, 18 Mar 2016 08:14:08 -0500
X-Gmail-Original-Message-ID: <CAL_JsqJ+PGgr8MAYH8onEDX-6DRmVR+Y-iOcw=JUZ3rfeq1ieg@mail.gmail.com>
Message-ID: <CAL_JsqJ+PGgr8MAYH8onEDX-6DRmVR+Y-iOcw=JUZ3rfeq1ieg@mail.gmail.com>
Subject: Re: [PATCH v5 1/4] dt-bindings: power: reset: add document for
 reboot-mode driver
To: Andy Yan <andy.yan@rock-chips.com>
Cc: John Stultz <john.stultz@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
        =?UTF-8?Q?Heiko_St=C3=BCbner?= <heiko@sntech.de>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Olof Johansson <olof@lixom.net>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        Sebastian Reichel <sre@kernel.org>, Jun Nie <jun.nie@linaro.org>,
        Eduardo Valentin <edubezval@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Will Deacon <will.deacon@arm.com>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>,
        Caesar Wang <wxt@rock-chips.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Russell King - ARM Linux <linux@arm.linux.org.uk>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Moritz Fischer <moritz.fischer@ettus.com>, richard@nod.at,
        David Woodhouse <dwmw2@infradead.org>,
        Julius Werner <jwerner@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1068
Lines: 38

On Fri, Mar 18, 2016 at 3:43 AM, Andy Yan <andy.yan@rock-chips.com> wrote:
> Hi Rob:
>
>
> On 2016年03月17日 23:52, Rob Herring wrote:
>>
>> On Tue, Mar 08, 2016 at 08:23:05PM +0800, Andy Yan wrote:
>>>
>>> add device tree bindings document for reboot-mode driver
>>>
>>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>

[...]

>>> +Required properties:
>>> +- compatible: should be "syscon-reboot-mode"
>>> +- offset: offset in the register map for the storage register (in bytes)
>>> +
>>> +Optional properity:
>>> +- mask: the mask bits of the mode magic value, default set to 0xffffffff
>>> if missing.
>>
>> I can't see how this is used. I would drop it for now.
>>
>> With that change:
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>
>
> The mask is suggested by Moritz Fischer in V2[0]. And I found Tegra did
> indeed only use some bits of one register to store the reboot mode[1].

And the other bits in the register need to be preserved? Please make
it clear the mask is for the register, not the magic value.

There's also a typo with "properity".

Rob