Subject: Re: [PATCH] nios2: Replace fdt_translate_address with
 of_flat_dt_translate_address
To: Ley Foon Tan <lftan@altera.com>
References: <1458269396-971-1-git-send-email-linux@roeck-us.net>
 <56EB7478.9080401@hurleysoftware.com> <1458280683.2963.11.camel@ubuntu>
Cc: Guenter Roeck <linux@roeck-us.net>, nios2-dev@lists.rocketboards.org,
        linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>
From: Peter Hurley <peter@hurleysoftware.com>
Message-ID: <56EC0279.1010205@hurleysoftware.com>
Date: Fri, 18 Mar 2016 06:28:25 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1458280683.2963.11.camel@ubuntu>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 968
Lines: 30

On 03/17/2016 10:58 PM, Ley Foon Tan wrote:
> On Thu, 2016-03-17 at 20:22 -0700, Peter Hurley wrote:
>> Hi Guenter,
>>
>> On 03/17/2016 07:49 PM, Guenter Roeck wrote:
>>> nios2 builds fail with the following build error.
>>>
>>> arch/nios2/kernel/prom.c: In function 'early_init_dt_scan_serial':
>>> arch/nios2/kernel/prom.c:100:2: error:
>>> 	implicit declaration of function 'fdt_translate_address'
>>>
>>> Commit c90fe9c0394b ("of: earlycon: Move address translation to
>>> of_setup_earlycon()") replaced fdt_translate_address() with
>>> of_flat_dt_translate_address() but missed updating the nios2 code.
>>
>> My bad.
>> The sad part is I even noted this other user of fdt_translate_address()
>> in a review of a different patch, and then overlooked it in my own patch. :/
>>
>> Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
>>
> Hi Peter,
> 
> Will you take this patch or you want me to take this?
> Thanks.

Please take this patch.

Regards,
Peter Hurley