Date: Fri, 18 Mar 2016 14:12:06 -0400
From: Don Zickus <dzickus@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org, mingo@kernel.org,
        tglx@linutronix.de
Subject: Re: [PATCH 1/2] watchdog: Fix output
Message-ID: <20160318181206.GS64531@redhat.com>
References: <20160318152802.407611377@infradead.org>
 <20160318153022.027826871@infradead.org>
 <20160318163748.GR64531@redhat.com>
 <20160318164441.GI6344@twins.programming.kicks-ass.net>
 <20160318164858.GX6375@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160318164858.GX6375@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 690
Lines: 19

On Fri, Mar 18, 2016 at 05:48:58PM +0100, Peter Zijlstra wrote:
> On Fri, Mar 18, 2016 at 05:44:41PM +0100, Peter Zijlstra wrote:
> > On Fri, Mar 18, 2016 at 12:37:48PM -0400, Don Zickus wrote:
> > > Would something like this be a better patch?
> > 
> > > -#define pr_fmt(fmt) "NMI watchdog: " fmt
> > > +#define pr_fmt(fmt) "Lockup detector: " fmt
> 
> You might want to audit all the other pr_ nonsense in that file; a lot
> of the msgs don't particularly make sense when combined with the prefix.
> 
> Some are for the NMI thing, others for the soft lockup one.
> 
> I would just chuck pr_crap() altogether and use sensible text.

Hehe.  I'll look into that next week.  :-)

Cheers,
Don