Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755341AbcCRSfw (ORCPT ); Fri, 18 Mar 2016 14:35:52 -0400 Received: from www.linutronix.de ([62.245.132.108]:38161 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750994AbcCRSfu (ORCPT ); Fri, 18 Mar 2016 14:35:50 -0400 Date: Fri, 18 Mar 2016 19:34:12 +0100 (CET) From: Thomas Gleixner To: Kan Liang cc: peterz@infradead.org, ak@linux.intel.com, eranian@google.com, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 1/2] x86/perf/intel/uncore: Make Intel uncore modular In-Reply-To: <1458298116-2610-1-git-send-email-kan.liang@intel.com> Message-ID: References: <1458298116-2610-1-git-send-email-kan.liang@intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 647 Lines: 22 On Fri, 18 Mar 2016, kan.liang@intel.com wrote: > From: Kan Liang > > This patch makes Intel uncore pmu driver modular. > By default, the uncore driver will be built in the kernel. If it is > configured as module, the supported cpu model can be auto loaded. > This patch also cleans up the code of cpu_init and pci_init. Nice work! > +static struct intel_uncore_init_fun skl_uncore_init = { > + .pci_init = skl_uncore_pci_init, > +}; > + > +static const struct x86_cpu_id intel_uncore_match[] = { Shouldn't all of these structs be const __initconst? Other than that: Reviewed-by: Thomas Gleixner