From: "Liang, Kan" <kan.liang@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
CC: "peterz@infradead.org" <peterz@infradead.org>,
        "ak@linux.intel.com" <ak@linux.intel.com>,
        "eranian@google.com" <eranian@google.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V2 1/2] x86/perf/intel/uncore: Make Intel uncore modular
Thread-Topic: [PATCH V2 1/2] x86/perf/intel/uncore: Make Intel uncore modular
Thread-Index: AQHRgUH79tz8hgPjW02IHATta1EEjp9fAOgAgACKkWA=
Date: Fri, 18 Mar 2016 18:51:00 +0000
Message-ID: <37D7C6CF3E00A74B8858931C1DB2F077058A6FD6@SHSMSX103.ccr.corp.intel.com>
References: <1458298116-2610-1-git-send-email-kan.liang@intel.com>
 <alpine.DEB.2.11.1603181932230.3978@nanos>
In-Reply-To: <alpine.DEB.2.11.1603181932230.3978@nanos>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 761
Lines: 30


> 
> On Fri, 18 Mar 2016, kan.liang@intel.com wrote:
> 
> > From: Kan Liang <kan.liang@intel.com>
> >
> > This patch makes Intel uncore pmu driver modular.
> > By default, the uncore driver will be built in the kernel. If it is
> > configured as module, the supported cpu model can be auto loaded.
> > This patch also cleans up the code of cpu_init and pci_init.
> 
> Nice work!
> 
> > +static struct intel_uncore_init_fun skl_uncore_init = {
> > +	.pci_init = skl_uncore_pci_init,
> > +};
> > +
> > +static const struct x86_cpu_id intel_uncore_match[] = {
> 
> Shouldn't all of these structs be const __initconst?
>

Thanks for the review. I will fix it in next version.

Thanks,
Kan

> Other than that:
> 
> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>