Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756028AbcCRSym (ORCPT ); Fri, 18 Mar 2016 14:54:42 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54713 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752170AbcCRSyj (ORCPT ); Fri, 18 Mar 2016 14:54:39 -0400 Message-ID: <56EC4EEA.8040201@osg.samsung.com> Date: Fri, 18 Mar 2016 18:54:34 +0000 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: linux-kernel@vger.kernel.org CC: johannes@sipsolutions.net, davem@davemloft.net, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] mac80211: add doc for RX_FLAG_DUP_VALIDATED flag References: <1458317369-28185-1-git-send-email-luisbg@osg.samsung.com> In-Reply-To: <1458317369-28185-1-git-send-email-luisbg@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1649 Lines: 45 On 18/03/16 16:09, Luis de Bethencourt wrote: > Add documentation for the flag for duplication check. > > Fixes the following warning when running make htmldocs: > warning: Enum value 'RX_FLAG_DUP_VALIDATED' not described in enum 'mac80211_rx_flags' > > Signed-off-by: Luis de Bethencourt > --- > Hi, > > While running make htmldocs I noticed a warning about RX_FLAG_DUP_VALIDATED > missing a description. This patch fixes this. > > I have noticed the order of the descriptions of the mac80211_rx_flags doesn't > match the order in the enum. I am happy to fix this if it would be of interest. > > Thanks, > Luis > > include/net/mac80211.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/net/mac80211.h b/include/net/mac80211.h > index a53333c..42c8cde 100644 > --- a/include/net/mac80211.h > +++ b/include/net/mac80211.h > @@ -1001,6 +1001,8 @@ ieee80211_tx_info_clear_status(struct ieee80211_tx_info *info) > * flag indicates that the PN was verified for replay protection. > * Note that this flag is also currently only supported when a frame > * is also decrypted (ie. @RX_FLAG_DECRYPTED must be set) > + * @RX_FLAG_DUP_VALIDATED: Set this flag for the driver to check for packet > + * duplication by itself. > * @RX_FLAG_FAILED_FCS_CRC: Set this flag if the FCS check failed on > * the frame. > * @RX_FLAG_FAILED_PLCP_CRC: Set this flag if the PCLP check failed on > Please ignore the second patch I replied to this one. It is wrong due to my misunderstanding. This above patch adding RX_FLAG_DUP_VALIDATED is correct and I believe it to be valid. Thanks for the reviews, Luis