Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756510AbcCRTTr (ORCPT ); Fri, 18 Mar 2016 15:19:47 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:33231 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751795AbcCRTTn (ORCPT ); Fri, 18 Mar 2016 15:19:43 -0400 Subject: Re: [PATCH] serial-uartlite: fix build warning To: Maarten Brock , Geert Uytterhoeven , Sudip Mukherjee References: <20160318184856.c289c591@kerio.vanmierlo.com> Cc: Peter Korsgaard , Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org From: Peter Hurley Message-ID: <56EC54CC.90101@hurleysoftware.com> Date: Fri, 18 Mar 2016 12:19:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160318184856.c289c591@kerio.vanmierlo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2012 Lines: 49 On 03/18/2016 10:48 AM, Maarten Brock wrote: > ----- Original Message ----- > From: Geert Uytterhoeven [mailto:geert@linux-m68k.org] > To: Sudip Mukherjee [mailto:sudipm.mukherjee@gmail.com] > Cc: Peter Korsgaard [mailto:jacmet@sunsite.dk], Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org], Jiri Slaby [mailto:jslaby@suse.com], linux-kernel@vger.kernel.org [mailto:linux-kernel@vger.kernel.org], linux-serial@vger.kernel.org [mailto:linux-serial@vger.kernel.org] > Sent: Fri, 18 Mar 2016 13:48:06 +0100 > Subject: Re: [PATCH] serial-uartlite: fix build warning > > >> On Thu, Mar 10, 2016 at 2:14 PM, Sudip Mukherjee >> wrote: >>> We were getting build warnings about: >>> drivers/tty/serial/uartlite.c: In function ‘ulite_request_port’: >>> drivers/tty/serial/uartlite.c:348:21: warning: assignment discards >>> 'const' qualifier from pointer target type >>> port->private_data = &uartlite_be; >>> ^ >>> drivers/tty/serial/uartlite.c:354:22: warning: assignment discards >>> 'const' qualifier from pointer target type >>> port->private_data = &uartlite_le; >>> ^ >>> >>> Fixes: 2905697a82ea ("serial-uartlite: Constify uartlite_be/uartlite_le") >>> Signed-off-by: Sudip Mukherjee >> >> Acked-by: Geert Uytterhoeven >> >> Gr{oetje,eeting}s, >> >> Geert > > Reverting is not the same as fixing. I agree; better to revert commit 2905697a82ea and let Maarten re-submit a patch that doesn't generate build warnings. > Rant: > It is a stupid warning IMHO, but being a compiler writer myself (SDCC) I > understand how it can arise. If you assign some const pointer to a void > pointer without an explicit cast gcc does not complain about the complete > loss of type, but it does warn about losing constness. In general I'd say: > make up your mind; either warn about both or don't warn about either. memcpy Regards, Peter Hurley