Date: Fri, 18 Mar 2016 13:32:35 -0700
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: Maarten Brock <m.brock@vanmierlo.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Peter Korsgaard <jacmet@sunsite.dk>, Jiri Slaby <jslaby@suse.com>,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial-uartlite: fix build warning
Message-ID: <20160318203235.GA3560@kroah.com>
References: <20160318184856.c289c591@kerio.vanmierlo.com>
 <56EC54CC.90101@hurleysoftware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <56EC54CC.90101@hurleysoftware.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1785
Lines: 40

On Fri, Mar 18, 2016 at 12:19:40PM -0700, Peter Hurley wrote:
> On 03/18/2016 10:48 AM, Maarten Brock wrote:
> > ----- Original Message -----
> > From: Geert Uytterhoeven [mailto:geert@linux-m68k.org]
> > To: Sudip Mukherjee [mailto:sudipm.mukherjee@gmail.com]
> > Cc: Peter Korsgaard [mailto:jacmet@sunsite.dk], Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org], Jiri Slaby [mailto:jslaby@suse.com], linux-kernel@vger.kernel.org [mailto:linux-kernel@vger.kernel.org], linux-serial@vger.kernel.org [mailto:linux-serial@vger.kernel.org]
> > Sent: Fri, 18 Mar 2016 13:48:06 +0100
> > Subject: Re: [PATCH] serial-uartlite: fix build warning
> > 
> > 
> >> On Thu, Mar 10, 2016 at 2:14 PM, Sudip Mukherjee
> >> <sudipm.mukherjee@gmail.com> wrote:
> >>> We were getting build warnings about:
> >>> drivers/tty/serial/uartlite.c: In function ‘ulite_request_port’:
> >>> drivers/tty/serial/uartlite.c:348:21: warning: assignment discards
> >>>         'const' qualifier from pointer target type
> >>> port->private_data = &uartlite_be;
> >>>                      ^
> >>> drivers/tty/serial/uartlite.c:354:22: warning: assignment discards
> >>>         'const' qualifier from pointer target type
> >>> port->private_data = &uartlite_le;
> >>>                       ^
> >>>
> >>> Fixes: 2905697a82ea ("serial-uartlite: Constify uartlite_be/uartlite_le")
> >>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> >>
> >> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >>
> >> Gr{oetje,eeting}s,
> >>
> >>                         Geert
> > 
> > Reverting is not the same as fixing.
> 
> I agree; better to revert commit 2905697a82ea and let Maarten re-submit
> a patch that doesn't generate build warnings.

I'll fix this up after 4.6-rc1 is out, thanks.

greg k-h