Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756750AbcCRVeO (ORCPT ); Fri, 18 Mar 2016 17:34:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:54927 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbcCRVeL (ORCPT ); Fri, 18 Mar 2016 17:34:11 -0400 Subject: Re: [PATCH] ARM: dts: rockchip: Add mdio node to ethernet node To: Tomeu Vizoso , linux-kernel@vger.kernel.org References: <1458300056-6174-1-git-send-email-tomeu.vizoso@collabora.com> Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , Heiko Stuebner , Pawel Moll , Ian Campbell , Rob Herring , Kumar Gala , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Giuseppe Cavallaro From: =?UTF-8?Q?Andreas_F=c3=a4rber?= X-Enigmail-Draft-Status: N1110 Organization: SUSE Linux GmbH Message-ID: <56EC744F.90308@suse.de> Date: Fri, 18 Mar 2016 22:34:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1458300056-6174-1-git-send-email-tomeu.vizoso@collabora.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1178 Lines: 40 Am 18.03.2016 um 12:20 schrieb Tomeu Vizoso: > So the dwmac device manages to probe again. > > Signed-off-by: Tomeu Vizoso > Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression") > --- > arch/arm/boot/dts/rk3288-rock2-som.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi > index 1ece66f3e162..4ba7ddecb478 100644 > --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi > +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi > @@ -101,6 +101,14 @@ > snps,reset-delays-us = <0 10000 30000>; > rx_delay = <0x10>; > tx_delay = <0x30>; > + mdio0 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "snps,dwmac-mdio"; > + ethphy1: ethernet-phy@1 { > + reg = <1>; > + }; > + }; This is a) ugly for lack of white lines in between, b) unnecessary since this is being fixed in the stmmac driver where it will benefit more than just this one SoM. Regards, Andreas > }; > > &i2c0 { -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N?rnberg)